From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org,
Christopher Larson <clarson@kergoth.com>,
Ionut Chisanovici <ionutx.chisanovici@intel.com>
Subject: Re: are the fetch-related variables in bitbake's bitbake.conf of any value?
Date: Wed, 25 Jun 2014 11:03:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1406251101540.32233@localhost> (raw)
In-Reply-To: <2353794.PEErK2dypV@peggleto-mobl5.ger.corp.intel.com>
On Wed, 25 Jun 2014, Paul Eggleton wrote:
> On Friday 20 June 2014 12:23:12 Robert P. J. Day wrote:
> > On Fri, 20 Jun 2014, Christopher Larson wrote:
> > > On Fri, Jun 20, 2014 at 9:00 AM, Robert P. J. Day <rpjday@crashcourse.ca>
> > > wrote:
> > >
> > > more specific question related to my earlier post -- is there any
> > > value whatever in the variables in bitbake's bitbake.conf file of the
> > > form:
> > >
> > > FETCHCOMMAND*
> > > RESUMECOMMAND*
> > > UPDATECOMMAND*
> > > MKTEMP*CMD
> > >
> > > nothing seems to use any of those. can they all just be deleted?
> > > certainly, the FETCHCOMMAND* variables have been superseded by the
> > > FETCHCMD* variables, no? i don't know about the remainder of them.
> > >
> > > As far as I know, as you say, those were deprecated in favor of the
> > > FETCHCMD vars, so can almost certainly be dropped.
> >
> > one more question before i submit a patch to do some cleaning.
> > AFAICT, the bitbake.conf settings for RESUMECOMMAND* and
> > UPDATECOMMAND* variables can be removed as well since nothing in
> > bitbake refers to those variables, and it seems logical that bitbake
> > should not be setting variables that it doesn't directly use in some
> > way.
>
> Those look old to me as well.
>
> > however, i'm puzzled by this from the bitbake codebase:
> >
> > $ grep -r "MKTEMP.*CMD" *
> > conf/bitbake.conf:MKTEMPCMD = "mktemp -q ${TMPBASE}"
> > conf/bitbake.conf:MKTEMPDIRCMD = "mktemp -d -q ${TMPBASE}"
> > lib/toaster/orm/fixtures/orm_views_testdata.json: "variable_name":
> > "MKTEMPCMD" lib/toaster/orm/fixtures/orm_views_testdata.json:
> > "variable_name": "MKTEMPDIRCMD" $
> >
> > so the only reference to the MKTEMP-related variables are in the
> > toaster directory in some .json files. what does that mean? if one
> > wanted to remove the MKTEMP* variables, would one also have to
> > adjust those .json files accordingly?
>
> The intention is to provide a way for QA verify that Toaster is
> collecting the variable data correctly, but because the json files
> contain every variable value, they are already out-of-date. We
> probably ought to filter the list that is used for that test to make
> it more maintainable.
so, in short, it should be safe to ditch the
{FETCH,RESUME,UPDATE}COMMAND variable settings, but i'm still unclear
on what would need to be done re: the MKTEMP* variables -- i'll just
submit a patch taking out the first set, and let someone else worry
about the ones that show up in json files.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2014-06-25 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:00 are the fetch-related variables in bitbake's bitbake.conf of any value? Robert P. J. Day
2014-06-20 16:08 ` Christopher Larson
2014-06-20 16:23 ` Robert P. J. Day
2014-06-25 14:02 ` Paul Eggleton
2014-06-25 15:03 ` Robert P. J. Day [this message]
2014-06-25 15:32 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1406251101540.32233@localhost \
--to=rpjday@crashcourse.ca \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
--cc=ionutx.chisanovici@intel.com \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.