Re: is it "addtask do_X ..." or "addtask X ..." or does it matter?

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Mon, 14 Jul 2014, Christopher Larson wrote:

> On Mon, Jul 14, 2014 at 3:11 AM, Robert P. J. Day <rpjday@crashcourse.ca>
> wrote:
>
> > if what chris writes is accurate, there are some broken class and
> > recipe files in oe-core:
> >
> > classes/kernel.bbclass:addtask do_strip before do_sizecheck after
> > do_kernel_link_vmlinux
> > classes/staging.bbclass:addtask do_populate_sysroot_setscene
> > classes/insane.bbclass:addtask do_package_qa after do_packagedata
> > do_package before do_build
> > classes/insane.bbclass:addtask do_package_qa_setscene
> > classes/package_rpm.bbclass:addtask do_package_write_rpm_setscene
> > classes/license.bbclass:addtask do_populate_lic_setscene
> > classes/archiver.bbclass:addtask do_ar_original after do_unpack
> > classes/archiver.bbclass:addtask do_unpack_and_patch after do_patch
> > classes/archiver.bbclass:addtask do_ar_patched after do_unpack_and_patch
> > classes/archiver.bbclass:addtask do_ar_configured after do_unpack_and_patch
> > classes/archiver.bbclass:addtask do_dumpdata
> > classes/archiver.bbclass:addtask do_ar_recipe
> > classes/archiver.bbclass:addtask do_deploy_archives before do_build
> > classes/deploy.bbclass:addtask do_deploy_setscene
> > classes/package_deb.bbclass:addtask do_package_write_deb_setscene
> > classes/package.bbclass:addtask do_package_setscene
> > classes/package.bbclass:addtask do_packagedata_setscene
> > classes/package_ipk.bbclass:addtask do_package_write_ipk_setscene
> > recipes-core/eglibc/eglibc-package.inc:addtask do_install_locale after
> > do_install before do_populate_sysroot do_package
> > recipes-core/base-passwd/base-passwd_3.5.29.bb:addtask do_package after
> > do_populate_sysroot
> > recipes-core/meta/package-index.bb:addtask do_package_index before
> > do_build
> > recipes-devtools/gcc/gcc-configure-common.inc:addtask do_preconfigure
> > after do_patch before do_configure
> > recipes-support/boost/boost.inc:addtask do_boostconfig after do_patch
> > before do_configure
> >
> >   surely all of the above can't be broken, can they?
> >
>
> I stand corrected, looks like code in bb.build.addtask automatically
> adds do_ if it isn't present. We probably should pick one and fix
> the metadata to be consistent, however :)

  ah, yes, there it is:

def addtask(task, before, after, d):
    if task[:3] != "do_":
        task = "do_" + task

  that just invites abuse, doesn't it? :-)

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================