From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Christopher Larson <clarson@kergoth.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: two variations for distro-specific FILESEXTRAPATHS prepending
Date: Wed, 16 Jul 2014 15:26:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1407161523410.4207@localhost> (raw)
In-Reply-To: <CABcZANnfhoCkE_ttWfcGA4PMJQ3YH912XrTHP6AH=9QAf8z=0Q@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2052 bytes --]
On Wed, 16 Jul 2014, Christopher Larson wrote:
>
> On Wed, Jul 16, 2014 at 4:26 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> just ran across this in the meta-yocto layer but it's a general OE
> question -- the psplash_git.bbappend file contains the following
> distro-conditional line:
>
> FILESEXTRAPATHS_prepend_poky := "${THISDIR}/files:"
>
> and the accompanying files/ directory has, unsurprisingly, a
> poky-specific splash image file, "psplash-poky-img.h".
>
> but based on how FILESEXTRAPATHS is processed by incorporating all
> of the FILESOVERRIDES variations (one of which is the distro name),
> would it not have been entirely equivalent to have used simply
>
> FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>
> and placed that splash file in the accompanying directory files/poky/?
> would these two approaches do the same thing? is there a preferred
> way? that's the only example of that i've seen in all the layers i've
> played with.
>
>
> Both would do the same thing, I'm personally of the opinion that the
> latter would be more consistent with how such things are normally
> done.
i was ready to bet internal organs that they had the same effect,
but i've perused the OE code base enough that i trip over oddities and
i just really want to make sure i know what i'm looking at.
rday
p.s. if someone wants to submit a poky patch that changes that, feel
free. otherwise, i'll just use it in class as a "check out what
someone did *here*!" example. :-)
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
prev parent reply other threads:[~2014-07-16 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 11:26 two variations for distro-specific FILESEXTRAPATHS prepending Robert P. J. Day
2014-07-16 16:36 ` Christopher Larson
2014-07-16 19:26 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1407161523410.4207@localhost \
--to=rpjday@crashcourse.ca \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.