All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: why does sysfsutils-2.1.0.bb set S = "${WORKDIR}/sysfsutils-${PV}"?
Date: Fri, 23 Oct 2015 08:57:39 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.20.1510230854570.5915@localhost> (raw)
In-Reply-To: <2338694.BfAL3tqMdu@peggleto-mobl.ger.corp.intel.com>

On Fri, 23 Oct 2015, Paul Eggleton wrote:

> Hi Robert,
>
> On Friday 23 October 2015 08:02:11 Robert P. J. Day wrote:
> >   side note: the first in a small set of posts where i simply want to
> > clarify minor oddities i run across in oe-core, not because they have
> > any desperate need to be fixed, but more because when i'm teaching
> > courses in oe/yocto, i run across the occasional weirdness that
> > puzzles students, and forces me to try to explain it, and sometimes
> > the explanation is, "that's just silly." so here's the first one.
> >
> >   as i read in bitbake.conf, the default source directory for any
> > recipe is defined as:
> >
> >   S = "${WORKDIR}/${BP}"
> >
> > which suggests that, as long as processing a recipe ends up using that
> > value as the source directory, there is no need for a recipe to
> > redefine S. kind of obvious, no?
> >
> >   in the case of sysfsutils-2.1.0.bb, one sees the line:
> >
> > S = "${WORKDIR}/sysfsutils-${PV}"
> >
> > which, given the standard definitions for variables BP and PV, seems
> > to expand into precisely the default value given in bitbake.conf.
> >
> >   so, unless i'm missing something, is there any actual need for that
> > line in the sysfsutils recipe file? is there something more subtle
> > going on here that i don't understand?
>
> I don't think so, it appears that line goes way back to the initial
> population of the repository. Looks like we could just drop it.

  thanks for the clarification. i realize that stuff like this is
annoyingly pedantic for developers and expert users, but it's
*exactly* the kind of thing students in my classes occasionally point
out and ask me to explain, and i stand there looking kind of baffled,
muttering, "what the hell ..."

  i'm about to update all my courseware so i'll just collect as many
of those as i can find and submit as a single patch.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




  reply	other threads:[~2015-10-23 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 12:02 why does sysfsutils-2.1.0.bb set S = "${WORKDIR}/sysfsutils-${PV}"? Robert P. J. Day
2015-10-23 12:49 ` Paul Eggleton
2015-10-23 12:57   ` Robert P. J. Day [this message]
2015-10-23 13:08     ` Paul Eggleton
2015-10-26 10:23   ` Robert P. J. Day
2015-10-26 10:34     ` Paul Eggleton
2015-10-26 10:40       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1510230854570.5915@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.