All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: still seems to be a pile of "_append +=" stuff in oe-core
Date: Sun, 22 Nov 2015 07:04:53 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.20.1511220702250.16489@localhost> (raw)


  i mentioned this a while back, and it *seems* that there's even more
of this now -- the use of "_append" in conjunction with "+=", which is
clearly(?) redundant.

  one simply needs to run:

$ grep -r "_append.*+=" *

to see how much of that there is. sure, it doesn't hurt, but it's
definitely not good programming practice.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



             reply	other threads:[~2015-11-22 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 12:04 Robert P. J. Day [this message]
2015-11-23  1:24 ` still seems to be a pile of "_append +=" stuff in oe-core Robert Yang
2015-11-23  2:05   ` Christopher Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1511220702250.16489@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.