All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Bob Tracy <rct@gherkin.frus.com>
Cc: Helge Deller <deller@gmx.de>, Matt Turner <mattst88@gmail.com>,
	linux-alpha <linux-alpha@vger.kernel.org>,
	Debian Alpha Mailing List <debian-alpha@lists.debian.org>,
	Michael Cree <mcree@orcon.net.nz>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [BUG] 4.9.0 build error on Alpha
Date: Thu, 12 Jan 2017 12:52:35 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.20.1701120056320.19339@eddie.linux-mips.org> (raw)
In-Reply-To: <20170103001536.GB14773@gherkin.frus.com>

Bob,

> Credit to all who participated in working this issue.  Matt -- attached
> is a patch set to be applied against the kernel.org 4.9.0 source tree.
> If it passes inspection, please approve and forward upstream.
> 
> Apologies for not including in-line, but I don't trust my mailer to
> preserve formatting unless I send as an attachment.

 Thanks for your contribution; you need to add a `Signed-off-by' tag 
though for your change to go anywhere.

 Also I think the <asm/uaccess.h> part will need some further work; at the 
very least the comment needs to be updated to state why the conditional 
has now been hardwired.  Ultimately I think all the hackery can go and 
`__copy_tofrom_user_nocheck' and `__clear_user' be replaced with direct 
calls to `__copy_user' and `__do_clear_user' respectively (and 
`__do_clear_user' renamed to `__clear_user' at the same time) as the +/- 
4MiB branch range is too low these days to guarantee a kernel binary to 
fit within.

 Alternatively a configuration option might be added for the branch 
optimisation to stay instead if selected, perhaps also adding the 
`-msmall-text' compiler option to let small configurations take advantage 
of it globally rather than just in <asm/uaccess.h>.  This might not be 
liked by people running build bots though as it would inevitably cause 
some configurations to fail linking.

  Maciej

      reply	other threads:[~2017-01-12 12:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  3:08 [BUG] 4.9.0 build error on Alpha Bob Tracy
2016-12-30  3:23 ` Matt Turner
2016-12-30  3:37   ` Bob Tracy
2016-12-30 16:02     ` Maciej W. Rozycki
2016-12-30 21:07       ` Helge Deller
2016-12-31  6:43         ` Bob Tracy
2016-12-31  7:20           ` Bob Tracy
2016-12-31 10:11             ` Maciej W. Rozycki
2016-12-31 15:20               ` Bob Tracy
2016-12-31 19:38                 ` Michael Cree
2016-12-31 21:09                   ` Bob Tracy
2017-01-01  1:23                 ` Maciej W. Rozycki
2017-01-01  3:32                   ` Bob Tracy
2017-01-01 20:29                     ` Bob Tracy
2017-01-03  0:15                       ` Bob Tracy
2017-01-12 12:52                         ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1701120056320.19339@eddie.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=debian-alpha@lists.debian.org \
    --cc=deller@gmx.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    --cc=rct@gherkin.frus.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.