diff for duplicates of <alpine.LFD.2.20.1711272054440.2808@localhost> diff --git a/a/1.txt b/N1/1.txt index f05753d..2f1912e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Sun, 26 Nov 2017, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > -> pkcs7_validate_trust_one() used 'x509->next = x509' to identify a +> pkcs7_validate_trust_one() used 'x509->next == x509' to identify a > self-signed certificate. That's wrong; ->next is simply the link in the > linked list of certificates in the PKCS#7 message. It should be > checking ->signer instead. Fix it. @@ -24,8 +24,8 @@ On Sun, 26 Nov 2017, Eric Biggers wrote: > /* Self-signed certificates form roots of their own, and if we > * don't know them, then we can't accept them. > */ -> - if (x509->next = x509) { -> + if (x509->signer = x509) { +> - if (x509->next == x509) { +> + if (x509->signer == x509) { > kleave(" = -ENOKEY [unknown self-signed]"); > return -ENOKEY; > } diff --git a/a/content_digest b/N1/content_digest index 8dae1c2..29e9a96 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020171127071942.26214-1-ebiggers3@gmail.com\0" "From\0James Morris <james.l.morris@oracle.com>\0" "Subject\0Re: [PATCH] pkcs7: fix check for self-signed certificate\0" - "Date\0Mon, 27 Nov 2017 09:54:52 +0000\0" + "Date\0Mon, 27 Nov 2017 20:54:52 +1100 (AEDT)\0" "To\0Eric Biggers <ebiggers3@gmail.com>\0" "Cc\0keyrings@vger.kernel.org" David Howells <dhowells@redhat.com> @@ -13,7 +13,7 @@ "\n" "> From: Eric Biggers <ebiggers@google.com>\n" "> \n" - "> pkcs7_validate_trust_one() used 'x509->next = x509' to identify a\n" + "> pkcs7_validate_trust_one() used 'x509->next == x509' to identify a\n" "> self-signed certificate. That's wrong; ->next is simply the link in the\n" "> linked list of certificates in the PKCS#7 message. It should be\n" "> checking ->signer instead. Fix it.\n" @@ -35,8 +35,8 @@ "> \t\t /* Self-signed certificates form roots of their own, and if we\n" "> \t\t * don't know them, then we can't accept them.\n" "> \t\t */\n" - "> -\t\tif (x509->next = x509) {\n" - "> +\t\tif (x509->signer = x509) {\n" + "> -\t\tif (x509->next == x509) {\n" + "> +\t\tif (x509->signer == x509) {\n" "> \t\t\tkleave(\" = -ENOKEY [unknown self-signed]\");\n" "> \t\t\treturn -ENOKEY;\n" "> \t\t}\n" @@ -49,4 +49,4 @@ "James Morris\n" <james.l.morris@oracle.com> -587a83f0a46d574a77a7fb4497cf13681bc8154afa5d18699f8005b55ee9668c +4145d9bf302a148106afc8ca4b3a2de74af6783dd4c9285ff4cfd248e545c9f5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.