From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 9/9] nvme: submit internal commands through the block layer
Date: Fri, 22 May 2015 17:36:12 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1505221731500.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <1432285966-31770-10-git-send-email-hch@lst.de>
On Fri, 22 May 2015, Christoph Hellwig wrote:
> - req->errors = nvme_error_status(status);
> + if (req->cmd_type == REQ_TYPE_DRV_PRIV) {
> + req->sense_len = le32_to_cpup(&cqe->result);
> + req->errors = status;
> + } else {
> + req->errors = nvme_error_status(status);
> + }
The "sense_len" is now the command result, but it's getting set only in
the error case, so the initial set features for number of queues gets
the wrong result; the driver creates only one IO queue when I wanted a
lot more.
next prev parent reply other threads:[~2015-05-22 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 9:12 nvme patchbomb, take 3 Christoph Hellwig
2015-05-22 9:12 ` [PATCH 1/9] nvme: consolidate synchronous command submission helpers Christoph Hellwig
2015-05-22 9:12 ` [PATCH 2/9] nvme: store a struct device pointer in struct nvme_dev Christoph Hellwig
2015-05-22 9:12 ` [PATCH 3/9] nvme: split nvme_trans_send_fw_cmd Christoph Hellwig
2015-05-22 9:12 ` [PATCH 4/9] nvme: fix scsi translation error handling Christoph Hellwig
2015-05-22 9:12 ` [PATCH 5/9] nvme: first round at deobsfucating the SCSI translation code Christoph Hellwig
2015-05-22 9:12 ` [PATCH 6/9] nvme: simplify and cleanup the READ/WRITE SCSI CDB parsing code Christoph Hellwig
2015-05-22 9:12 ` [PATCH 7/9] nvme: report the DPOFUA in MODE_SENSE Christoph Hellwig
2015-05-22 9:12 ` [PATCH 8/9] nvme: fail SCSI read/write command with unsupported protection bit Christoph Hellwig
2015-05-22 9:12 ` [PATCH 9/9] nvme: submit internal commands through the block layer Christoph Hellwig
2015-05-22 17:36 ` Keith Busch [this message]
2015-05-22 18:01 ` Keith Busch
2015-05-22 14:42 ` nvme patchbomb, take 3 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1505221731500.15930@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.