From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Thu, 30 Jul 2015 20:00:13 +0000 (UTC) Subject: [PATCH V2] NVMe: Using PRACT bit to generate and verify PI by controller In-Reply-To: <1438094033-2693-1-git-send-email-pandey.alok@samsung.com> References: <1438094033-2693-1-git-send-email-pandey.alok@samsung.com> Message-ID: On Tue, 28 Jul 2015, Alok Pandey wrote: > This patch enables the PRCHK and reftag support when PRACT bit is set, and > block layer integrity is disabled. Thanks! Reviewed-by: Keith Busch > Signed-off-by: Alok Pandey > --- > @@ -815,11 +815,10 @@ static int nvme_submit_iod(struct nvme_queue *nvmeq, struct nvme_iod *iod, > cmnd->rw.slba = cpu_to_le64(nvme_block_nr(ns, blk_rq_pos(req))); > cmnd->rw.length = cpu_to_le16((blk_rq_bytes(req) >> ns->lba_shift) - 1); > > - if (blk_integrity_rq(req)) { > - cmnd->rw.metadata = cpu_to_le64(sg_dma_address(iod->meta_sg)); > + if (ns->ms) { > switch (ns->pi_type) { > case NVME_NS_DPS_PI_TYPE3: > - control |= NVME_RW_PRINFO_PRCHK_GUARD; > + control |= NVME_RW_PRINFO_PRCHK_GUARD; > break; Though the tab change here must have been an accident.