From: James Morris <jmorris@namei.org>
To: Eric Paris <eparis@redhat.com>
Cc: selinux@tycho.nsa.gov, sds@tycho.nsa.gov
Subject: Re: [PATCH] SELinux: hold tasklist_lock and siglock while waking wait_chldexit
Date: Wed, 5 Nov 2008 08:46:27 +1100 (EST) [thread overview]
Message-ID: <alpine.LRH.1.10.0811050845350.1992@tundra.namei.org> (raw)
In-Reply-To: <1225829906.3320.10.camel@localhost.localdomain>
On Tue, 4 Nov 2008, Eric Paris wrote:
> From: Eric Paris <eparis@redhat.com>
>
> SELinux has long been calling wake_up_interruptible() on
> current->parent->signal->wait_chldexit without holding any locks. It
> appears that this operation should hold the tasklist_lock to dereference
> current->parent and we should hold the siglock when waking up the
> signal->wait_chldexit.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
This seems correct to me, too, although I'll just push it to
security-testing#next at least for the moment so it gets some testing.
How did you find this issue?
--
James Morris
<jmorris@namei.org>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-11-04 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 20:18 [PATCH] SELinux: hold tasklist_lock and siglock while waking wait_chldexit Eric Paris
2008-11-04 21:46 ` James Morris [this message]
2008-11-04 21:50 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0811050845350.1992@tundra.namei.org \
--to=jmorris@namei.org \
--cc=eparis@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.