From: Alan Maguire <alan.maguire@oracle.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: brendanhiggins@google.com, davidgow@google.com,
alan.maguire@oracle.com, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v3 0/2] kunit: fail tests on UBSAN errors
Date: Wed, 10 Feb 2021 10:34:41 +0000 (GMT) [thread overview]
Message-ID: <alpine.LRH.2.23.451.2102101034050.25339@localhost> (raw)
In-Reply-To: <20210209221443.78812-1-dlatypov@google.com>
On Tue, 9 Feb 2021, Daniel Latypov wrote:
> v1 by Uriel is here: [1].
> Since it's been a while, I've dropped the Reviewed-By's.
>
> It depended on commit 83c4e7a0363b ("KUnit: KASAN Integration") which
> hadn't been merged yet, so that caused some kerfuffle with applying them
> previously and the series was reverted.
>
> This revives the series but makes the kunit_fail_current_test() function
> take a format string and logs the file and line number of the failing
> code, addressing Alan Maguire's comments on the previous version.
>
> As a result, the patch that makes UBSAN errors was tweaked slightly to
> include an error message.
>
> v2 -> v3:
> Fix kunit_fail_current_test() so it works w/ CONFIG_KUNIT=m
> s/_/__ on the helper func to match others in test.c
>
> [1] https://lore.kernel.org/linux-kselftest/20200806174326.3577537-1-urielguajardojr@gmail.com/
>
For the series:
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Thanks!
prev parent reply other threads:[~2021-02-10 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 22:14 [PATCH v3 0/2] kunit: fail tests on UBSAN errors Daniel Latypov
2021-02-09 22:14 ` [PATCH v3 1/2] kunit: support failure from dynamic analysis tools Daniel Latypov
2021-02-11 8:54 ` David Gow
2021-02-11 15:40 ` Alan Maguire
2021-02-11 20:58 ` Daniel Latypov
2021-02-11 21:33 ` Brendan Higgins
2021-02-17 0:23 ` Daniel Latypov
2021-02-09 22:14 ` [PATCH v3 2/2] kunit: ubsan integration Daniel Latypov
2021-02-10 22:00 ` kernel test robot
2021-02-10 22:00 ` kernel test robot
2021-02-11 7:15 ` kernel test robot
2021-02-11 7:15 ` kernel test robot
2021-02-10 10:34 ` Alan Maguire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.23.451.2102101034050.25339@localhost \
--to=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.