From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Dickins Subject: Re: [PATCH 2/2] cgroup: bring back kill_cnt to order css destruction Date: Wed, 12 Feb 2014 16:38:25 -0800 (PST) Message-ID: References: <20140207164321.GE6963@cmpxchg.org> <20140213002853.GC2916@htj.dyndns.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=RQBE9byUU74N/uyWGwa8yXi3aenunHpYkvD0w+Tktcs=; b=e2ifjUQzDPrvU0eeYpZBQj0a3cy6XOcn2ecgwnAdQ7QQiuGmypbw85ghq2uMTJA9BE IGsja6n5Y/+o9lMLO/bSJvo3k8lUZe4q3wcD6xhyUka5X+fQT7T/eKO856/MjVPEndw9 9hYA8pjwRAwPs1ZqC8X12BqNx8o7K80TsgF+lFDY9o1S1h6e4i+0HxO0g0HxWhIsLwZs CxsMdBFq2YZ3QAseyGWusDZ7VG3+dLZ2AKsSzHDj11cQBxE4Kyg/s12NC/Rw1mmWS9+d qQsWfp4hBu/F5rsmjbSnWFJ8EMh4mxn1x7m45vGtuR8UkLyHdtnWopTpl9ulqI6w9vsi A+YQ== In-Reply-To: <20140213002853.GC2916@htj.dyndns.org> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Hugh Dickins , Michal Hocko , Johannes Weiner , Filipe Brandenburger , Li Zefan , Andrew Morton , Greg Thelen , Michel Lespinasse , Markus Blank-Burian , Shawn Bohrer , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, 12 Feb 2014, Tejun Heo wrote: > > Not that your implementation is bad or anything but the patch itself > somehow makes me cringe a bit. It's probably just because it has to > add to the already overly complicated offline path. Guaranteeing > strict offline ordering might be a good idea but at least for the > immediate bug fix, I agree that the memcg specific fix seems better > suited. Let's apply that one and reconsider this one if it turns out > we do need strict offline reordering. Yes, I agree completely - thanks. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbaBMAjU (ORCPT ); Wed, 12 Feb 2014 19:39:20 -0500 Received: from mail-pd0-f173.google.com ([209.85.192.173]:50351 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbaBMAjS (ORCPT ); Wed, 12 Feb 2014 19:39:18 -0500 Date: Wed, 12 Feb 2014 16:38:25 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Tejun Heo cc: Hugh Dickins , Michal Hocko , Johannes Weiner , Filipe Brandenburger , Li Zefan , Andrew Morton , Greg Thelen , Michel Lespinasse , Markus Blank-Burian , Shawn Bohrer , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] cgroup: bring back kill_cnt to order css destruction In-Reply-To: <20140213002853.GC2916@htj.dyndns.org> Message-ID: References: <20140207164321.GE6963@cmpxchg.org> <20140213002853.GC2916@htj.dyndns.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Feb 2014, Tejun Heo wrote: > > Not that your implementation is bad or anything but the patch itself > somehow makes me cringe a bit. It's probably just because it has to > add to the already overly complicated offline path. Guaranteeing > strict offline ordering might be a good idea but at least for the > immediate bug fix, I agree that the memcg specific fix seems better > suited. Let's apply that one and reconsider this one if it turns out > we do need strict offline reordering. Yes, I agree completely - thanks. Hugh