From: Miroslav Benes <mbenes@suse.cz>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: jpoimboe@kernel.org, jikos@kernel.org, pmladek@suse.com,
joe.lawrence@redhat.com, song@kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v9 5/9] livepatch: Implement provides and obsoletes for scoped atomic replace
Date: Tue, 29 Sep 2026 10:44:15 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2609291043430.18161@pobox.suse.cz> (raw)
In-Reply-To: <CALOAHbAnQ-g_NSEWWj5dzpJsMuxibQ3ROqkrR1FeX1aPd=xEcw@mail.gmail.com>
> > > @@ -496,10 +496,10 @@ void klp_try_complete_transition(void)
> > > * klp_complete_transition() but it is called also
> > > * from klp_cancel_transition().
> > > */
> > > - if (!patch->enabled)
> > > - klp_free_patch_async(patch);
> > > - else if (patch->replace)
> > > + if (patch->enabled)
> > > klp_free_replaced_patches_async(patch);
> > > + else
> > > + klp_free_patch_async(patch);
> > > }
> >
> > A total nit but just s/else if/else/ would also be fine here, no?
>
> In v7, Petr suggested inverting the logic instead to improve readability [0].
>
> [0]. https://lore.kernel.org/all/apfSMN5a9PTxTTsW@pathway.suse.cz/
Fair enough.
Miroslav
next prev parent reply other threads:[~2026-09-29 8:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 2:42 [PATCH v9 0/9] livepatch: Add support for scoped atomic replace Yafang Shao
2026-09-13 2:42 ` [PATCH v9 1/9] selftests/livepatch: Clarify test module file names Yafang Shao
2026-09-25 8:54 ` Miroslav Benes
2026-09-13 2:42 ` [PATCH v9 2/9] selftests/livepatch: Adapt atomic replace tests to provides/obsoletes Yafang Shao
2026-09-25 8:54 ` Miroslav Benes
2026-09-28 2:55 ` Yafang Shao
2026-09-29 8:42 ` Miroslav Benes
2026-09-29 9:25 ` Yafang Shao
2026-09-13 2:42 ` [PATCH v9 3/9] livepatch: Make klp_find_func() non static Yafang Shao
2026-09-13 2:42 ` [PATCH v9 4/9] livepatch: Call klp_init_patch_early() earlier Yafang Shao
2026-09-13 2:55 ` sashiko-bot
2026-09-13 2:57 ` Yafang Shao
2026-09-13 2:42 ` [PATCH v9 5/9] livepatch: Implement provides and obsoletes for scoped atomic replace Yafang Shao
2026-09-25 11:59 ` Miroslav Benes
2026-09-28 3:09 ` Yafang Shao
2026-09-29 8:44 ` Miroslav Benes [this message]
2026-09-13 2:42 ` [PATCH v9 6/9] livepatch: Deprecate stack_order Yafang Shao
2026-09-13 2:48 ` sashiko-bot
2026-09-13 2:55 ` Yafang Shao
2026-09-25 13:00 ` Miroslav Benes
2026-09-13 2:42 ` [PATCH v9 7/9] selftests/livepatch: Add provides/obsoletes test scenarios Yafang Shao
2026-09-25 12:57 ` Miroslav Benes
2026-09-28 3:10 ` Yafang Shao
2026-09-13 2:42 ` [PATCH v9 8/9] selftests/livepatch: Add state test for provides/obsoletes Yafang Shao
2026-09-13 2:42 ` [PATCH v9 9/9] selftests/livepatch: Add function " Yafang Shao
2026-09-24 20:56 ` [PATCH v9 0/9] livepatch: Add support for scoped atomic replace Song Liu
2026-09-25 7:49 ` Petr Mladek
2026-09-28 2:32 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2609291043430.18161@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.