From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF3120E6E2 for ; Fri, 17 Jul 2026 17:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784309371; cv=none; b=j/3YqbpT2rErjRY/d8Cu4Bc8yUwWFCYIXuVyg99pGZAVi9lgo/Gr8kXiTqPAGgb3UljP81XEd/U/uTRJi36uBiOrpxVGfDtq1kNlz+3yCg87D+or0qxs4zqh6ky7iRzmjczeJZMeJDhTBlm8rzmbxa+Kd5Ka0GFV1OGPZEyUaLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784309371; c=relaxed/simple; bh=8g8Fj6fZwJkWf2LHlawUKlAnXX87CiWciF2uzpX+CEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dDDDwlbuO5iDtUyreoIEci2QOdgksuamhnJLZXKTuBH6s9z78FGLf4jZXqczlUkCb/7rbtJCnzdtnAZqtyJQsf16arRDlE/kUxzaUR3TNG+vMDL/4+C0iaKocw0B+aiYUFXGTcsvS6lM5CWlDqgzZDFsKciZ4oimNg0fhnMDZNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=gy5ls/v5; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gy5ls/v5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ShAyE7VO4VQr7VJkjYidYF7ZGJiAyrO0e9dbnSofcoE=; b=gy5ls/v5DFYXBSnSkHKb+74z4S 3SIaALod+T3PkugLOkqOq5a7IxkBzRu7hUwQqDukFRsLBCOSHDDUeQ0SjsWzwG5v9bpH7WNOcaec6 oa8mSwRytBv7+ZsVtTWOMrScFxcjT5QDFdjmWKcsZBFQHDjIaftMSO06aOJ+62snr3IAZoXV72b+k jnoyr9Q0kyIN9e2wp4S8znnsGy+X2D7M/oC0cgj8Wka1PhmTy47Y23igH/9cSWRTSGPzYsu0eSXyO exrgXEfLAWAeD7iiclU+jS1uq+Rb7Hd9xUx/b3NDf/hYQMw78GLvlIJ13o1jO2cDK747fE4zpCbdp oV58RPqA==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkmNE-00000005QQB-2KcZ; Fri, 17 Jul 2026 17:29:20 +0000 Date: Fri, 17 Jul 2026 18:29:20 +0100 From: Matthew Wilcox To: Hongfu Li Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Message-ID: References: <20260717072054.74260-1-hongfu.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717072054.74260-1-hongfu.li@linux.dev> On Fri, Jul 17, 2026 at 03:20:54PM +0800, Hongfu Li wrote: > From: Hongfu Li > > unlock_page(), end_page_writeback() and wait_on_page_writeback() > are void wrappers forwarding to folio-based functions which also > return void. Explicit return statements here are syntactically valid > but unnecessary, and inconsistent with other nearby compat helpers > such as mark_page_accessed() and set_page_writeback(). > > Drop all these superfluous return keywords. why bother? this file is temporary scaffolding. if they offend you so much, work on removing the need for them.