From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7111C14AD0D for ; Sun, 19 Jul 2026 16:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784478069; cv=none; b=VRC8GmUvvq6N50ytX+OyHnZSWtyLLzUyUZ1ergUGZnjrDqoJENsiB3vyBPRw2Mm8svVNXsjdJijV8kGJDHF4+jGGRaX3wmkyOcbjVJ/XxbEwbkmz84HFolkVnKeCBSmHuPl25LnYWrFX0aDGEDl8DQwCQR94tt4bpEJ/qs6F7bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784478069; c=relaxed/simple; bh=OeOegcTEt8msYeNQ4L4WHgxYlu/AztVnmC4sFUUhKrk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bf9FJEPQ3yIY9Tun7kOpPRX4iXfoNY/EKMsPcJT9D96eFz7aSzVXFiyfaR4BIfyMsW4IDbr+3BIkZreuXoz8KNYgZKABaDbab9p/FsIna7B4kXDkQyr91YupyMhO/j+WmVWrF5iXTivf2NepMC25O5MB105KIOdDJZ8HP4SbwE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VnKU8BsV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VnKU8BsV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784478066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J48LYbSKrhuwQn5HZe255emjY9LPbktGoiE0WMTvqAo=; b=VnKU8BsVHy4TBcayMDnwYzi+MgANNJJ6DSoFBaZgVRcmczTiUjUX04sfxE3oWSdEqXP5a5 c7nno3OkqT822JvclO0oIKMwgHIHwQbKXTZTseAQitU2nOpO3VGAb351rWS1qDATtVz7ef esDzcW14S4NV5CjGShticmFKqb8LUZA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-7FAm0JMNNWiurzliIrUMnQ-1; Sun, 19 Jul 2026 12:21:02 -0400 X-MC-Unique: 7FAm0JMNNWiurzliIrUMnQ-1 X-Mimecast-MFC-AGG-ID: 7FAm0JMNNWiurzliIrUMnQ_1784478060 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A54BA1800BE7; Sun, 19 Jul 2026 16:20:59 +0000 (UTC) Received: from fedora (unknown [10.44.49.164]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 9C6A51800595; Sun, 19 Jul 2026 16:20:54 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 19 Jul 2026 18:20:59 +0200 (CEST) Date: Sun, 19 Jul 2026 18:20:53 +0200 From: Oleg Nesterov To: "Cen Zhang (Microsoft)" Cc: brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, avagin@gmail.com, ptikhomirov@virtuozzo.com, mjguzik@gmail.com, include@grrlz.net, ebiederm@xmission.com, legion@kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid Message-ID: References: <20260719155842.7069-1-blbllhy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260719155842.7069-1-blbllhy@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 07/19, Cen Zhang (Microsoft) wrote: > > Move kill_cad_pid() out of the header without changing behavior. This > prepares for taking a reference to cad_pid under RCU in the following > fix. ... > +int kill_cad_pid(int sig, int priv) > +{ > + return kill_pid(cad_pid, sig, priv); > +} Well... this version doesn't address another comment from sashiko. Without EXPORT_SYMBOL() this can break the modules which use kill_cad_pid(). Say, drivers/acpi/tiny-power-button.c I am starting to think that we should apply my patch first, it is more straightforward. Your 2/2 can be trivially rebased on top of it. Oleg.