From: Nicolas Schier <nsc@kernel.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: akpm@linux-foundation.org, arnd@arndb.de, ojeda@kernel.org,
tglx@kernel.org, gary@garyguo.net,
thomas.weissschuh@linutronix.de, aliceryhl@google.com,
leitao@debian.org, dianders@chromium.org, linux.amoon@gmail.com,
oleg@redhat.com, peterz@infradead.org, andreas@gaisler.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nohz: replace dead select with choice default
Date: Sun, 2 Aug 2026 21:40:02 +0200 [thread overview]
Message-ID: <am-dEt7eWVGkpfOd@levanger> (raw)
In-Reply-To: <20260801160140.2391000-1-julianbraha@gmail.com>
On Sat, Aug 01, 2026 at 05:01:40PM +0100, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently the
> 'select VIRT_CPU_ACCOUNTING_GEN' for NO_HZ_FULL is dead, with the choice
> option VIRT_CPU_ACCOUNTING_GEN only being enabled when NO_HZ_FULL=y because
> the other choice members depend on NO_HZ_FULL=n.
>
> Let's remove the dead select, and encode this relationship as a default of
> the choice, instead.
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> init/Kconfig | 1 +
> kernel/time/Kconfig | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
Thanks!
Reviewed-by: Nicolas Schier <nsc@kernel.org>
next prev parent reply other threads:[~2026-08-02 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 16:01 [PATCH] nohz: replace dead select with choice default Julian Braha
2026-08-01 21:26 ` Bradley Morgan
2026-08-02 19:40 ` Nicolas Schier [this message]
2026-08-11 13:42 ` [tip: timers/core] nohz: Replace " tip-bot2 for Julian Braha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am-dEt7eWVGkpfOd@levanger \
--to=nsc@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=gary@garyguo.net \
--cc=julianbraha@gmail.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=ojeda@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.