From: Nicolas Schier <nsc@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
"Askar Safin" <safinaskar@gmail.com>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: Re: [PATCH v2 2/2] kbuild: Move gen_init_cpio and gen_initramfs.sh to scripts/
Date: Sat, 1 Aug 2026 21:44:34 +0200 [thread overview]
Message-ID: <am5Moi6DBgMSnuO1@levanger> (raw)
In-Reply-To: <178552657997.3004192.6811032535007922482.b4-review@b4>
On Fri, Jul 31, 2026 at 12:36:19PM -0700, Nathan Chancellor wrote:
> > diff --git a/usr/gen_init_cpio.c b/scripts/gen_init_cpio.c
> > similarity index 100%
> > rename from usr/gen_init_cpio.c
> > rename to scripts/gen_init_cpio.c
> > diff --git a/usr/gen_initramfs.sh b/scripts/gen_initramfs.sh
> > similarity index 99%
> > rename from usr/gen_initramfs.sh
> > rename to scripts/gen_initramfs.sh
> > index 7eba2fddf0ef..27ac1fd48001 100755
> > --- a/usr/gen_initramfs.sh
> > +++ b/scripts/gen_initramfs.sh
>
> The cpio commmand in scripts/Makefile.package needs an update for this
> move, otherwise modules-cpio-pkg will be broken.
Good catch, thanks!
> Additionally, I see a number of references to "usr/gen_init" even after
> this is applied:
>
> $ git grep usr/gen_init
> Documentation/driver-api/early-userspace/early_userspace_support.rst:usr/gen_init_cpio utility (run 'usr/gen_init_cpio -h' to get the
> Documentation/driver-api/early-userspace/early_userspace_support.rst:usr/gen_init_cpio.
[...]
> tools/testing/selftests/kho/vmtest.sh: "$build_dir/usr/gen_init_cpio" "$tmp_dir/cpio_list" > "$initrd"
> tools/testing/selftests/nolibc/Makefile.nolibc: $(QUIET_GEN)echo 'file /init nolibc-test 755 0 0' | $(objtree)/usr/gen_init_cpio - > initramfs.cpio
> usr/Kconfig: "usr/gen_init_cpio" program in the kernel tree.
oh well, thanks! I completely forgot checking for references.
> Otherwise, this seems reasonable to me. Feel free to carry
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> on the respin.
Will do, thank for the review!
Nicolas
prev parent reply other threads:[~2026-08-01 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 19:10 [PATCH v2 0/2] Move tool for generating initramfs cpio to scripts/ Nicolas Schier
2026-07-20 19:10 ` [PATCH v2 1/2] kbuild: Mark usr_gen_init_cpio as no-dot-config-target Nicolas Schier
2026-07-20 19:10 ` [PATCH v2 2/2] kbuild: Move gen_init_cpio and gen_initramfs.sh to scripts/ Nicolas Schier
2026-07-31 19:36 ` Nathan Chancellor
2026-08-01 19:44 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am5Moi6DBgMSnuO1@levanger \
--to=nsc@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=safinaskar@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.