From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5134B3F4835 for ; Wed, 22 Jul 2026 04:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784693966; cv=none; b=mVELTZJn6YajlTOzdj1u0vBxNfyIb2Ub8U5eouVpE6b2MKC4/aa0AivYWa3CwS5+pZOc/fQHow/2g5rSfO2MxkGCMu2KgIRQdLLbEDR2R7abjDDuDNerJjPbBBjtB/gAkwKVF978PqzK4uceY0nLq6InzJ3czfUlG6TBOLr8PzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784693966; c=relaxed/simple; bh=9WGq6TOnPFPtzjoCu2km1c5cncgwqgLdUyLgWxRW18g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R/60habv6oeLaD50vwhRe4hIy5xUA9tEoqI3DmZuyxkjqj09HI+EkC3KrHVS8vmZtSAUg/46p5TN+E+AKRrbuFAp/Z8QKfb7T/h2mQKTIFt577+Y2HnT9NW313RFZlzplXbiollnbvdguoiKu23baBVMfA/QIrx2SK1DjZlLUmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VqBUERcg; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VqBUERcg" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cace91f112so125631325ad.0 for ; Tue, 21 Jul 2026 21:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784693962; x=1785298762; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7ZyY1l4SComaripzfwSmuIT5HdbD6ZYoRdYmUR46E5I=; b=VqBUERcgpX8TxIONtLmfIGhzX/Csdj655F+RKoVrCPoRiaZFJuwWl+Lzcp6iBnO3MW oXnGTOn6FQYcna+Cd0RsjCGGjrV/Kp86RJsJvpUI5uN7SHuVzTXbNqoJJC/OIX0v1Hbq tfsBTux3TqRf9Oj1pS+AEZS/p2Nw6bAormdR8nOBRQFNHYI7Mt428TIlWV72CnZjtd4q i/3DkRQdR5wywlKIqt4l1fvnzNTCtDYIrBXIfItZqEt/3d70X2ottq6mi2VTiPaxNyXJ M5wsefKi7YSCaXb5EbmAD9mTvB6o+Vow0pxzsldeyO8iqKT40nogS8bc+8P68gsEXpX7 Z9DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784693962; x=1785298762; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7ZyY1l4SComaripzfwSmuIT5HdbD6ZYoRdYmUR46E5I=; b=XVnvPSXK+cTkJ6igFCdK+ovyx6R04PqFy4XYBPC6H/R9wyuUxdSEpK354NsJXjHFK2 rrxKGnMW6w9htvDz6Am7Cna/FLm9qi1nvJDUBq1G912SjMQJ0lZNe2IwjGs0pb0mOYdB 3R3xrgfBvvVlnOl8Bw7tUsi64Q3/1FDNTikTtdSrQJFHPpRvNUvuqe34F3lDQQmBa0uG R3QWf7OSAlZgGSUctDLZo24BdBdoAEHTIIc7RUlZNczfGwd6UHQq+gIhOWIeT8Kgcacw QqlxJdyFaVqMUEBFrfD6WvX/tA4pMDUZ5JZbcX6HaEzVx1q9CPDuANUYmsdulYhxftBQ G4Ig== X-Forwarded-Encrypted: i=1; AHgh+RqsAJIBKhcOAgoOM1fqx/6JehpTzOBb3D4AXKGSlltb1jjbjMGe0K1J9ecNC3R5lD93t62NF+IQnL0xQt0=@vger.kernel.org X-Gm-Message-State: AOJu0YxBpcD29bYxHK8c0FAjJWZV2aIFutBV8Co0YiCRbRbU32JDoqEl h6lhKtX0MM+cZQh4KunHC0c/YdOoFS73jdrtH0AtfhwbOeYSfsCWbTVMygfAbQ== X-Gm-Gg: AR+sD13ZHIiDAJzvZroKZdqxCKIJm7jEW/t1tpfhkk4SWM7IpW7dnA1d/nqJMKbiHFD 1Jf1KuFK3dE2r37tNhQFaCZjbCuXhzPRiSzeAaXKsuwh3B6MowU5dnQKcfbI5ULpPTf0BBOf2ai sPia9mtED5J5lJaljKt1ONduTToNnW+GP6wCmRbQxu0TvkezTExwLJjA+FDMzJh+kUiLX6FQi2J oTq7rh6YIPLRsN/Yce93Ujs9PbUyUMDLUVnQ6Xf6GUPpksQu8FsIowHeWvJ4cX39be3v0emIbbT lnh5wx1clwm0CCR2M2WyjabrCr6qXCKi+C975WRzvcxNTrKkvZmSfR2MxpSlttWIUOLNNA1eS3A eQrNXx0EN1k8QRymAQkw80iDJ+PtJGvJEBzi7oV8L8KJ0eS2jHQELjM3O7DhpPzTN2temQozFTz w6eeoQ1JFtElyUpPftQIaVbvA0Zefn5N+RmhZaq6MFBOLrZm0= X-Received: by 2002:a17:903:3d06:b0:2c9:960c:f73b with SMTP id d9443c01a7336-2cf349bb795mr222451375ad.24.1784693962419; Tue, 21 Jul 2026 21:19:22 -0700 (PDT) Received: from google.com ([2a00:79e0:2039:4:e1c9:b467:ed38:9c4c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8efa9918sm7044095ad.16.2026.07.21.21.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 21:19:21 -0700 (PDT) Date: Wed, 22 Jul 2026 12:19:16 +0800 From: Kuan-Wei Chiu To: Jyun-An Chen Cc: Jonathan Corbet , Shuah Khan , "open list:MIN HEAP" , "open list:DOCUMENTATION" Subject: Re: [PATCH v3] Documentation/core-api: min_heap: remove documented but unimplemented min_heap_empty() Message-ID: References: <20260721184334.143152-1-jun930436@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721184334.143152-1-jun930436@gmail.com> On Tue, Jul 21, 2026 at 06:43:34PM +0000, Jyun-An Chen wrote: > min_heap_empty()/min_heap_empty_inline() are documented as part of > the Min Heap API, but no such functions or macros exist in > include/linux/min_heap.h or lib/min_heap.c. Remove the stale > description instead of adding unused API surface. I think we can drop the last clause "instead of adding unused API surface". It reads like unnecessary AI generated text. Regards, Kuan-Wei > > Signed-off-by: Jyun-An Chen > Acked-by: Kuan-Wei Chiu > --- > Changes since v2: > - Fixed subject line. > > Documentation/core-api/min_heap.rst | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/Documentation/core-api/min_heap.rst b/Documentation/core-api/min_heap.rst > index 9f57766581df..919dcf1bdec7 100644 > --- a/Documentation/core-api/min_heap.rst > +++ b/Documentation/core-api/min_heap.rst > @@ -240,19 +240,6 @@ This macro returns `true` if the heap is full, otherwise `false`. > > **Inline Version:** min_heap_full_inline(heap) > > -- **min_heap_empty(heap)**: Checks whether the heap is empty. > - Complexity: **O(1)**. > - > -.. code-block:: c > - > - bool empty = min_heap_empty(heap); > - > -- `heap`: A pointer to the min-heap to check. > - > -This macro returns `true` if the heap is empty, otherwise `false`. > - > -**Inline Version:** min_heap_empty_inline(heap) > - > Example Usage > ============= > > -- > 2.43.0 >