From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH v2 2/3] iotests: skip FUSE tests when FUSE is not usable
Date: Wed, 22 Jul 2026 09:46:41 +0100 [thread overview]
Message-ID: <amCDcaKeymbVGZAO@redhat.com> (raw)
In-Reply-To: <20260715103451.1930909-3-den@openvz.org>
On Wed, Jul 15, 2026 at 12:34:50PM +0200, Denis V. Lunev wrote:
> file-io-error, fuse-allow-other and fuse-mmap-shared skip only when
> FUSE is not compiled in. When FUSE is built in but unusable at run
> time (no /dev/fuse access, fusermount lacking permissions), the
> export fails to mount with "Failed to mount FUSE session to export"
> and the tests report a spurious failure instead of skipping, like
> NBD tests already do for missing NBD support.
>
> Add _notrun_on_fuse_error() to common.rc and use it in the shell
> tests. fuse-mmap-shared is Python, so it gets an equivalent inline
> check.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Hanna Reitz <hreitz@redhat.com>
> ---
> tests/qemu-iotests/common.rc | 14 ++++++++++++++
> tests/qemu-iotests/tests/file-io-error | 4 +---
> tests/qemu-iotests/tests/fuse-allow-other | 2 ++
> tests/qemu-iotests/tests/fuse-mmap-shared | 9 ++++++---
> 4 files changed, 23 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-07-22 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 10:34 [PATCH v2 0/3] iotests: fix three spurious local failures Denis V. Lunev
2026-07-15 10:34 ` [PATCH v2 1/3] iotests: run the test pool with the 'fork' start method Denis V. Lunev
2026-07-22 8:45 ` Daniel P. Berrangé
2026-07-15 10:34 ` [PATCH v2 2/3] iotests: skip FUSE tests when FUSE is not usable Denis V. Lunev
2026-07-22 8:46 ` Daniel P. Berrangé [this message]
2026-07-15 10:34 ` [PATCH v2 3/3] iotests/migrate-bitmaps-postcopy-test: replace the timing assertion with a content check Denis V. Lunev
2026-07-15 10:55 ` Vladimir Sementsov-Ogievskiy
2026-07-22 8:39 ` [PATCH v2 0/3] iotests: fix three spurious local failures Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amCDcaKeymbVGZAO@redhat.com \
--to=berrange@redhat.com \
--cc=den@openvz.org \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.