Re: [PATCH v2 3/5] ufs: derive the per-region RPMB CID and size for OP-TEE

[Jorge Ramirez via U-Boot <u-boot@lists.u-boot-project.org>]

On 22/07/26 10:33:29, neil.armstrong@linaro.org wrote:
> Hi,
> 
> On 7/22/26 08:07, Jorge Ramirez-Ortiz wrote:
> > Read the UFS device, unit and geometry descriptors to report each RPMB
> > region's size and reliable-write count, and build a 16-byte CID by
> > BLAKE2b-hashing the same device-id string the Linux kernel derives
> > (ufshcd_create_device_id() plus a "-R<region>" suffix), so OP-TEE derives
> > an RPMB key that matches Linux. Exposed via ufs_rpmb_get_region_info().
> > 
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> > ---
> >   drivers/ufs/ufs-rpmb.c   | 141 +++++++++++++++++++++++++++++++++++++++
> >   drivers/ufs/ufs-uclass.c |   4 +-
> >   drivers/ufs/ufs.h        |   2 +
> >   include/ufs.h            |   6 ++
> >   4 files changed, 151 insertions(+), 2 deletions(-)
> > 
> 
> <snip>
> 
> > diff --git a/drivers/ufs/ufs-uclass.c b/drivers/ufs/ufs-uclass.c
> > index e320a6dcfbc..3a0bcd287ea 100644
> > --- a/drivers/ufs/ufs-uclass.c
> > +++ b/drivers/ufs/ufs-uclass.c
> > @@ -1801,8 +1801,8 @@ out:
> >   	return err;
> >   }
> > -static int ufs_get_device_desc(struct ufs_hba *hba,
> > -			       struct ufs_dev_desc *dev_desc)
> > +int ufs_get_device_desc(struct ufs_hba *hba,
> > +			struct ufs_dev_desc *dev_desc)
> 
> I still don't find where ufs_get_device_desc() is used.

you right, missed it. will fix in v3