From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B12353A86; Wed, 22 Jul 2026 13:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727875; cv=pass; b=hwh6jNqx/vivZ1qC2ZlyiZFNglNMobxkEdVrpTY+7yvYy7IJDmpMoe2tpJ1cWYheINFaRWlO8B6butw9ik8ERnewi3O7BZMVZtvji7/7r4acy86X/heUehZv5QCa9O4RlT9ltKtG6NPfoHHhs2TGhIiFNtXbcmJE8IIuvsGLEA0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727875; c=relaxed/simple; bh=BGNGta0Th1BbHantorEBy2MK9WW2yjWjTxgQGn2Ki7A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DDgbuMSEzCjI5vLoi/hMa7E9poniSFacy13f1Fx1iyJ1NYMYNeCsjPfoRZzi8ybVV1FLg9l03iBY/Lv3YnGIGkSd9k9gVIDpTO6QeUBG2ayNxZFvD5ZY7c+9xZv77L0NWIHhQIpv5jWlVL9tr0/UTdGwIH/on/9LJowDpaRA2lw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b=h8g7xu2g; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b="h8g7xu2g" ARC-Seal: i=1; a=rsa-sha256; t=1784727845; cv=none; d=zohomail.com; s=zohoarc; b=h8tWv/wBPEDSBfIo/DI73iRDbFHi6RiaCVImxXmEgtIgy06N/KdSmmNQXwlJtlwvRZ8Ws3pE+JfhMQcbvemIkkSG00N6Q6z1BobqiKGTELk2mIN/dwo6rbGyjkzOnXIqudy40L+6wYU7MrvRy/qV15O1ThBsM3iqTOQjYd4FEOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784727845; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=BGNGta0Th1BbHantorEBy2MK9WW2yjWjTxgQGn2Ki7A=; b=DMYewNjgiNpe0C+Cm+cDQ7ekMukv8EOAg+FqPrc+2/QOswEHdCu/wTa4oJD6LgQAMvwLDwgT1r7HBcim7sGOhHxLKk/19NdeSJlm6N5QVVxpum1qs9ylbv6+GruKLJ55qIK6VYM90VSgs0h4SSDOkgEC1VQUrJgInxcUpiEbBGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784727845; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Content-Transfer-Encoding:Message-Id:Reply-To; bh=BGNGta0Th1BbHantorEBy2MK9WW2yjWjTxgQGn2Ki7A=; b=h8g7xu2gzADe2+6650Mi4Fd9f8IlRhciEePMNKtgYwoIK/GjN9aQtpfq5s8eLx0r YQlbfviEuQ9NjpUu0qwX/uejoEDU7nI7hhue0kbAlkFMQXv/sM3sTLxW4QS03P3ss6G hbKdZUj+xl700ISMi9tp5m85d1r/tCAUSy342ID8= Received: by mx.zohomail.com with SMTPS id 1784727842465237.23228134706085; Wed, 22 Jul 2026 06:44:02 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 608C318090F; Wed, 22 Jul 2026 15:43:57 +0200 (CEST) Date: Wed, 22 Jul 2026 15:43:57 +0200 From: Sebastian Reichel To: Quentin Schulz Cc: Alexey Charkov , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Wyon Bi , Finley Xiao , Elaine Zhang , Detlev Casanova , Sugar Zhang , YouMin Chen , Dragan Simic , Liang Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: Fractional PLL coefficient on RK3588/RK3576 is two's complement Message-ID: References: <20260721-rk3588-fracpll-v1-1-b289bf17cf17@flipper.net> <7f3924ab-52fc-4fb6-91b4-42a5e55d5c76@cherry.de> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.10.1.5.2/284.708.77 X-ZohoMailClient: External Hello Alexey, On Wed, Jul 22, 2026 at 02:59:25PM +0200, Quentin Schulz wrote: > On 7/22/26 1:00 PM, Alexey Charkov wrote: > > On Wed, Jul 22, 2026 at 2:35=E2=80=AFPM Quentin Schulz wrote: > > > On 7/21/26 9:17 PM, Alexey Charkov wrote: > > > > Not adding Cc stable, because while this fixes a real bug it's no= t a > > > > regression, as the issue was introduced in the same commit that a= dded the > > > > RK3576/RK3588 support. > > >=20 > > > I don't think this is a valid reason :) > >=20 > > I believe Linus frowns upon changes like "it never worked, but we've > > fixed it now" being submitted as fixes. It's been broken for years, > > and since nobody complained yet, going via the normal development pat= h > > (i.e. -next) seems perfectly fine to me. >=20 > My bet is because of the Fixes: it'll get backported anyway even > if you don't put Cc: stable. In any case, I don't care too much :) FWIW you are mixing up things. Linus does not handle the stable kernels. He does the release candidates and the initial version of every kernel release. The stable releases are handled by the stable maintainers. Linus only said, that he does not want to get these kind of fixes during late -rc phase. That makes sense considering fixes also have a chance of introducing regressions. But if patches end up in a pull request for an -rc kernel or in the pull request for the next merge window depends on the maintainer applying the patch (i.e. Heiko). The maintainer can queue a patch with all those tags into the normal for-next queue targeting the following merge window. This results in the patch being in linux-next for a while, then being added to the master branch during a merge window and then being added to the stable trees (as stable only picks patches that are in mainline). The maintainer can also merge a patch to the queue for -rc kernels without the Cc stable. That is exactly what happens for a regression from a normal patch in the merge window, since the affected patch wouldn't be in any stable kernel. TLDR: The Cc stable tag has nothing to do with Linus. Greetings, -- Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A72C44536 for ; Wed, 22 Jul 2026 13:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HYYYemCbhBtjr4SQ2/QE84AmolDe8chVOVMVb6krwXA=; b=ug2j9WUb3AcshZ wc/JUNmkRLOZ2BuXVreH4xHEfukxIGxNjJ7uxPjDOJZ1qLZPa28Y0xIsNQAXe9rqGrK2CYXDKjVAY KrNjpo/PFvZWYdu5Ytt8ynGyyzVJ9HaDQ7Nsvbyf4MfylHKxVHXjFS1wABOEaPoD0oTERm4Wmoi0B ACgy/debibG2zrAtJAAILdkxACsFiR2kiRouu3yKgGwIdKwjhmnSRbwat3zZdojCWAnLTyMjgSrEv WLaTQvehq9RH3KWWzdu8UMmDss7rvfyIJamBOsM7PKF+1FJ6ZBXqV9JUTcc9HNBRfW9bLbhP2Iler ZdWMVrS+fBrreNhGkJTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmXFD-0000000Bw2r-05K4; Wed, 22 Jul 2026 13:44:19 +0000 Received: from sender4-op-o11.zoho.com ([136.143.188.11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmXF9-0000000Bw1v-44xU; Wed, 22 Jul 2026 13:44:17 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1784727845; cv=none; d=zohomail.com; s=zohoarc; b=h8tWv/wBPEDSBfIo/DI73iRDbFHi6RiaCVImxXmEgtIgy06N/KdSmmNQXwlJtlwvRZ8Ws3pE+JfhMQcbvemIkkSG00N6Q6z1BobqiKGTELk2mIN/dwo6rbGyjkzOnXIqudy40L+6wYU7MrvRy/qV15O1ThBsM3iqTOQjYd4FEOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784727845; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=BGNGta0Th1BbHantorEBy2MK9WW2yjWjTxgQGn2Ki7A=; b=DMYewNjgiNpe0C+Cm+cDQ7ekMukv8EOAg+FqPrc+2/QOswEHdCu/wTa4oJD6LgQAMvwLDwgT1r7HBcim7sGOhHxLKk/19NdeSJlm6N5QVVxpum1qs9ylbv6+GruKLJ55qIK6VYM90VSgs0h4SSDOkgEC1VQUrJgInxcUpiEbBGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784727845; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Content-Transfer-Encoding:Message-Id:Reply-To; bh=BGNGta0Th1BbHantorEBy2MK9WW2yjWjTxgQGn2Ki7A=; b=h8g7xu2gzADe2+6650Mi4Fd9f8IlRhciEePMNKtgYwoIK/GjN9aQtpfq5s8eLx0r YQlbfviEuQ9NjpUu0qwX/uejoEDU7nI7hhue0kbAlkFMQXv/sM3sTLxW4QS03P3ss6G hbKdZUj+xl700ISMi9tp5m85d1r/tCAUSy342ID8= Received: by mx.zohomail.com with SMTPS id 1784727842465237.23228134706085; Wed, 22 Jul 2026 06:44:02 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 608C318090F; Wed, 22 Jul 2026 15:43:57 +0200 (CEST) Date: Wed, 22 Jul 2026 15:43:57 +0200 From: Sebastian Reichel To: Quentin Schulz Cc: Alexey Charkov , Michael Turquette , Stephen Boyd , Brian Masney , Heiko Stuebner , Wyon Bi , Finley Xiao , Elaine Zhang , Detlev Casanova , Sugar Zhang , YouMin Chen , Dragan Simic , Liang Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: Fractional PLL coefficient on RK3588/RK3576 is two's complement Message-ID: References: <20260721-rk3588-fracpll-v1-1-b289bf17cf17@flipper.net> <7f3924ab-52fc-4fb6-91b4-42a5e55d5c76@cherry.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.10.1.5.2/284.708.77 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260722_064416_067084_40C8FD04 X-CRM114-Status: GOOD ( 24.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gQWxleGV5LAoKT24gV2VkLCBKdWwgMjIsIDIwMjYgYXQgMDI6NTk6MjVQTSArMDIwMCwg UXVlbnRpbiBTY2h1bHogd3JvdGU6Cj4gT24gNy8yMi8yNiAxOjAwIFBNLCBBbGV4ZXkgQ2hhcmtv diB3cm90ZToKPiA+IE9uIFdlZCwgSnVsIDIyLCAyMDI2IGF0IDI6MzXigK9QTSBRdWVudGluIFNj aHVseiA8cXVlbnRpbi5zY2h1bHpAY2hlcnJ5LmRlPiB3cm90ZToKPiA+ID4gT24gNy8yMS8yNiA5 OjE3IFBNLCBBbGV4ZXkgQ2hhcmtvdiB3cm90ZToKPiA+ID4gPiBOb3QgYWRkaW5nIENjIHN0YWJs ZSwgYmVjYXVzZSB3aGlsZSB0aGlzIGZpeGVzIGEgcmVhbCBidWcgaXQncyBub3QgYQo+ID4gPiA+ IHJlZ3Jlc3Npb24sIGFzIHRoZSBpc3N1ZSB3YXMgaW50cm9kdWNlZCBpbiB0aGUgc2FtZSBjb21t aXQgdGhhdCBhZGRlZCB0aGUKPiA+ID4gPiBSSzM1NzYvUkszNTg4IHN1cHBvcnQuCj4gPiA+IAo+ ID4gPiBJIGRvbid0IHRoaW5rIHRoaXMgaXMgYSB2YWxpZCByZWFzb24gOikKPiA+IAo+ID4gSSBi ZWxpZXZlIExpbnVzIGZyb3ducyB1cG9uIGNoYW5nZXMgbGlrZSAiaXQgbmV2ZXIgd29ya2VkLCBi dXQgd2UndmUKPiA+IGZpeGVkIGl0IG5vdyIgYmVpbmcgc3VibWl0dGVkIGFzIGZpeGVzLiBJdCdz IGJlZW4gYnJva2VuIGZvciB5ZWFycywKPiA+IGFuZCBzaW5jZSBub2JvZHkgY29tcGxhaW5lZCB5 ZXQsIGdvaW5nIHZpYSB0aGUgbm9ybWFsIGRldmVsb3BtZW50IHBhdGgKPiA+IChpLmUuIC1uZXh0 KSBzZWVtcyBwZXJmZWN0bHkgZmluZSB0byBtZS4KPiAKPiBNeSBiZXQgaXMgYmVjYXVzZSBvZiB0 aGUgRml4ZXM6IGl0J2xsIGdldCBiYWNrcG9ydGVkIGFueXdheSBldmVuCj4gaWYgeW91IGRvbid0 IHB1dCBDYzogc3RhYmxlLiBJbiBhbnkgY2FzZSwgSSBkb24ndCBjYXJlIHRvbyBtdWNoIDopCgpG V0lXIHlvdSBhcmUgbWl4aW5nIHVwIHRoaW5ncy4gTGludXMgZG9lcyBub3QgaGFuZGxlIHRoZSBz dGFibGUKa2VybmVscy4gSGUgZG9lcyB0aGUgcmVsZWFzZSBjYW5kaWRhdGVzIGFuZCB0aGUgaW5p dGlhbCB2ZXJzaW9uIG9mCmV2ZXJ5IGtlcm5lbCByZWxlYXNlLiBUaGUgc3RhYmxlIHJlbGVhc2Vz IGFyZSBoYW5kbGVkIGJ5IHRoZSBzdGFibGUKbWFpbnRhaW5lcnMuIExpbnVzIG9ubHkgc2FpZCwg dGhhdCBoZSBkb2VzIG5vdCB3YW50IHRvIGdldCB0aGVzZQpraW5kIG9mIGZpeGVzIGR1cmluZyBs YXRlIC1yYyBwaGFzZS4gVGhhdCBtYWtlcyBzZW5zZSBjb25zaWRlcmluZwpmaXhlcyBhbHNvIGhh dmUgYSBjaGFuY2Ugb2YgaW50cm9kdWNpbmcgcmVncmVzc2lvbnMuCgpCdXQgaWYgcGF0Y2hlcyBl bmQgdXAgaW4gYSBwdWxsIHJlcXVlc3QgZm9yIGFuIC1yYyBrZXJuZWwgb3IgaW4gdGhlCnB1bGwg cmVxdWVzdCBmb3IgdGhlIG5leHQgbWVyZ2Ugd2luZG93IGRlcGVuZHMgb24gdGhlIG1haW50YWlu ZXIKYXBwbHlpbmcgdGhlIHBhdGNoIChpLmUuIEhlaWtvKS4gVGhlIG1haW50YWluZXIgY2FuIHF1 ZXVlIGEgcGF0Y2gKd2l0aCBhbGwgdGhvc2UgdGFncyBpbnRvIHRoZSBub3JtYWwgZm9yLW5leHQg cXVldWUgdGFyZ2V0aW5nIHRoZQpmb2xsb3dpbmcgbWVyZ2Ugd2luZG93LiBUaGlzIHJlc3VsdHMg aW4gdGhlIHBhdGNoIGJlaW5nIGluCmxpbnV4LW5leHQgZm9yIGEgd2hpbGUsIHRoZW4gYmVpbmcg YWRkZWQgdG8gdGhlIG1hc3RlciBicmFuY2ggZHVyaW5nCmEgbWVyZ2Ugd2luZG93IGFuZCB0aGVu IGJlaW5nIGFkZGVkIHRvIHRoZSBzdGFibGUgdHJlZXMgKGFzIHN0YWJsZQpvbmx5IHBpY2tzIHBh dGNoZXMgdGhhdCBhcmUgaW4gbWFpbmxpbmUpLgoKVGhlIG1haW50YWluZXIgY2FuIGFsc28gbWVy Z2UgYSBwYXRjaCB0byB0aGUgcXVldWUgZm9yIC1yYyBrZXJuZWxzCndpdGhvdXQgdGhlIENjIHN0 YWJsZS4gVGhhdCBpcyBleGFjdGx5IHdoYXQgaGFwcGVucyBmb3IgYSByZWdyZXNzaW9uCmZyb20g YSBub3JtYWwgcGF0Y2ggaW4gdGhlIG1lcmdlIHdpbmRvdywgc2luY2UgdGhlIGFmZmVjdGVkIHBh dGNoCndvdWxkbid0IGJlIGluIGFueSBzdGFibGUga2VybmVsLgoKVExEUjogVGhlIENjIHN0YWJs ZSB0YWcgaGFzIG5vdGhpbmcgdG8gZG8gd2l0aCBMaW51cy4KCkdyZWV0aW5ncywKCi0tIFNlYmFz dGlhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2Nr Y2hpcAo=