All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	netdev@vger.kernel.org, aravind.iddamsetty@linux.intel.com,
	anshuman.gupta@intel.com, rodrigo.vivi@intel.com,
	joonas.lahtinen@linux.intel.com, kuba@kernel.org,
	simona.vetter@ffwll.ch, airlied@gmail.com, pratik.bari@intel.com,
	joshua.santosh.ranjan@intel.com, ashwin.kumar.kulkarni@intel.com,
	shubham.kumar@intel.com, ravi.kishore.koppuravuri@intel.com,
	maarten.lankhorst@linux.intel.com, mallesh.koujalagi@intel.com,
	soham.purkait@intel.com,
	Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH v6 2/2] drm/xe/xe_ras: Report correctable/uncorrectable error events to userspace
Date: Wed, 22 Jul 2026 17:32:03 +0200	[thread overview]
Message-ID: <amDicxi7Bwuy1k2l@black.igk.intel.com> (raw)
In-Reply-To: <amDglMC44EIWChvp@black.igk.intel.com>

On Wed, Jul 22, 2026 at 05:24:11PM +0200, Raag Jadav wrote:
> On Wed, Jul 22, 2026 at 03:11:37PM +0530, Riana Tauro wrote:
> > When an interrupt is received for correctable errors indicating that error
> > counter has crossed its threshold, read the current counter value and
> > deliver a drm-ras error-event to userspace for each affected component.
> > 
> > Also send drm-ras error-event to userspace for uncorrectable errors on
> > receiving an AER.
> > 
> > To avoid sending duplicate events when the same component appears multiple
> > times in the response, Send the error-event once per component.
> 
> ...
> 
> > @@ -425,6 +487,12 @@ enum xe_ras_recovery_action xe_ras_process_errors(struct xe_device *xe)
> >  			xe_info(xe, "[RAS]: %s %s detected\n", comp_to_str(component),
> >  				sev_to_str(severity));
> 
> Similar to threshold crossed case, we should probably have a BUILD_BUG_ON()
> against XE_RAS_NUM_ERROR_ARR.

XE_RAS_COMP_MAX, missed it :)

> Reviewed-by: Raag Jadav <raag.jadav@intel.com>
> 
> > +			/* Send event once per component */
> > +			if (!(sent & BIT(component))) {
> > +				sent |= BIT(component);
> > +				ras_send_error_event(xe, severity, component);
> > +			}
> > +
> >  			switch (component) {
> >  			case XE_RAS_COMP_CORE_COMPUTE:
> >  				action = handle_core_compute_errors(arr);
> > -- 
> > 2.47.1
> > 

  reply	other threads:[~2026-07-22 15:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  9:41 [PATCH v6 0/2] Add drm_ras netlink error event support Riana Tauro
2026-07-22  9:41 ` [PATCH v6 1/2] drm/drm_ras: Add drm_ras netlink error event Riana Tauro
2026-07-23  9:42   ` sashiko-bot
2026-07-23 14:36   ` Tauro, Riana
2026-07-23 16:34     ` Rodrigo Vivi
2026-07-22  9:41 ` [PATCH v6 2/2] drm/xe/xe_ras: Report correctable/uncorrectable error events to userspace Riana Tauro
2026-07-22 15:24   ` Raag Jadav
2026-07-22 15:32     ` Raag Jadav [this message]
2026-07-23 15:03     ` Tauro, Riana
2026-07-23 16:08       ` Raag Jadav
2026-07-23 15:04     ` Tauro, Riana
2026-07-23 16:11       ` Raag Jadav
2026-07-23  6:41   ` Raag Jadav
2026-07-23  9:42   ` sashiko-bot
2026-07-22  9:49 ` ✓ CI.KUnit: success for Add drm_ras netlink error event support (rev6) Patchwork
2026-07-22 10:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-22 22:30 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amDicxi7Bwuy1k2l@black.igk.intel.com \
    --to=raag.jadav@intel.com \
    --cc=airlied@gmail.com \
    --cc=anshuman.gupta@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=ashwin.kumar.kulkarni@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=joshua.santosh.ranjan@intel.com \
    --cc=kuba@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pratik.bari@intel.com \
    --cc=ravi.kishore.koppuravuri@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=shubham.kumar@intel.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.