From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB45A18DB2A for ; Thu, 23 Jul 2026 01:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771985; cv=none; b=iCgcD/6Kv+mr6vo0vq7XQYhsy0xOM4pDB2JopO/HBdTtoDRB2rtB7kJL0f0tgjBUE7E+NUv8yxRTV58QxTv/osDFj8ZtfzbaT4K0aeyTGkC73cdVrkbbsY4tpgEzZ377XXy3KoWpfb66oD4gmFhLiIwJMw1ry0EP0Gu9KN2B/iY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771985; c=relaxed/simple; bh=w64hOozqaIcFFPfK6/6Trc+ayzg8PjRrNpXoQtbMPlA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IclvBbmur/cHAaRpOSnFLX+2+fuOjRg13EUm9tqrMLgG4irwC//hPPrXH6Pb1H13h7hUtapcFV6pCssnfMINDvWb7GAQm2VPAXxxNZeCOeR+Kz9A7oeYNVvFkmc3tPINyYK6I5fbGJjJpIUjzYvydKaUMcNEsnYq4xQdCGTpm3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=STNtMUIN; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="STNtMUIN" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c16ac21acso633791cf.0 for ; Wed, 22 Jul 2026 18:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1784771980; x=1785376780; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ME39BOUsgETsp9b9ZszwmQSxDI6GW0t/fX+N/500D9c=; b=STNtMUIN1RMMToSm9UANZ0sGVmlRnO2lGnBHwhc+lSEiwo2/4sP1FoAnLWc/AKYIvs 30LpAbhSc4DGKy3e/QM2HhJyBjwu19TbtvSRi4llbfXvLTmc2NlWxqs/F3wZctxxKAYD unYv73VEmnpQYAHuZnimYyC5nYtsesknv64PztElHcBvkqrqI/5PL1amUG4IYOKb/JMj IWPfWh8GCWIzapD7oxCFpQYbX39xkpiC9YSjETzMua/088hGRP5hfw5jYcRnZ+UY281Z eHcWTrd5uj38Zhmh3KNO/9Sqcaju1toH6pXxnneLDTZIwmmVq+T5L8YHEAcYjuJ43bj8 Ia/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784771980; x=1785376780; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ME39BOUsgETsp9b9ZszwmQSxDI6GW0t/fX+N/500D9c=; b=olrPDceKBfg0XwZJLaGu0ADscEGf8oOY8yvWWkJMpgRCYHVMFjB/cC9R57rf15uQoY QSBQKBSoCRTKm2AaEgYL18rXAATQNcPYR8T1HWZw3xpMAmVg0h3jnjM1GOPClbE0zypy 9qpAQewS14x8s6RqxVpK0J+/mPNj6ixl3xz3gyA3eJK9vazUVpf+O93h8ZfLy/0z6eiu CEEevz9rNP87WT1HDZ9E+JnVCej2hlR0MBoL8ltbRu7slvzrwLWBob8qt8fGrx30o4dT jymQ6RKL5govlSm+cCymMNPzzBMcvjd6CmF1CTdS5vxmzoihER0oQ8uQv+7kTvcUyNCu 4msQ== X-Forwarded-Encrypted: i=1; AHgh+RoPqMIhBH4f1KrXQ4xkhEkYre6hAI7EMQ415eQxo5roXtL+2k7q/2V8Gc2AZLBmpIxmpsjOlyKedyGc44U=@vger.kernel.org X-Gm-Message-State: AOJu0YzFgqlCPyZayt7F65sApVgz+3hRcVWrCoW8OzcPslIJd/sRRX59 Hlgad2cr5wyfAdydkalMbduNfoSnOqE9pkryVj6dlSZ2yqvod+0UbsfJC8eQmMYAHvs= X-Gm-Gg: AR+sD125HLQxnJ7X+F99UOC5RBz3+U7hOIZmnxT72bDaRYJ3TWwkWykn460AK361tpO Mc4Ak/3BV+VTNMf4THgVHRkYeLPP+ZuwgdKhSYqsgUQ/IjRw+XqcD6pcG9s6xpDH/9HEvXVHwge vOIALEEGxHmv+CIAmYuQo009pMu9KICDAtMEYuqkRAfXYpzPHz/TvsLP8F+5Us99688N3gLc2Ez cJV3Wvh+vPbLtgM0Ig8NWNoBdyeVBLDMeME+CpWZtEmBOZfFWtp49k7l5O3B2LlnHpYx/pbFlOk CGsCxbhunAmCchLDYD3lY/JpJGIyez4brJiFa0DZPsxbqj9qCJtHb4Q6fEsLqSz3Cn6sCLo8nVG ofLAODIynjLGbYnPnSrBsgFI9Xp4z7djGiH98ieNc3O2uMVJpgJkuZeNAX8oa8C/sPyQZ5ETU50 vr X-Received: by 2002:a05:620a:440f:b0:915:8f08:5fa7 with SMTP id af79cd13be357-931036d2152mr124807685a.52.1784771980540; Wed, 22 Jul 2026 18:59:40 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907ba9e18aesm34212396d6.25.2026.07.22.18.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 18:59:39 -0700 (PDT) Date: Wed, 22 Jul 2026 21:59:38 -0400 From: Johannes Weiner To: Ridong Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton , Chris Li , Kairui Song , Muchun Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , Qi Zheng , Lorenzo Stoakes , Axel Rasmussen , Yuanchu Xie , Wei Xu , Davidlohr Bueso , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH v2 1/2] memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h Message-ID: References: <20260716031729.1064007-1-ridong.chen@linux.dev> <20260716031729.1064007-2-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716031729.1064007-2-ridong.chen@linux.dev> Acked-by: Johannes Weiner One small suggestion: On Thu, Jul 16, 2026 at 11:17:28AM +0800, Ridong wrote: > @@ -76,6 +77,25 @@ enum swap_cluster_flags { > CLUSTER_FLAG_MAX, > }; > > +extern int vm_swappiness; > + > +static inline int mem_cgroup_swappiness(struct mem_cgroup *memcg) > +{ > +#ifdef CONFIG_MEMCG_V1 > + /* Cgroup2 doesn't have per-cgroup swappiness */ > + if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) > + return READ_ONCE(vm_swappiness); > + > + /* root ? */ > + if (mem_cgroup_disabled() || mem_cgroup_is_root(memcg)) > + return READ_ONCE(vm_swappiness); > + > + return READ_ONCE(memcg->swappiness); > +#else > + return READ_ONCE(vm_swappiness); > +#endif How about: #ifdef CONFIG_MEMCG_V1 if (!cgroup_subsys_on_dfl(memory_cgrp_subsys) && !mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) return memcg->swappiness; #endif return READ_ONCE(vm_swappiness);