From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 230BF36894D for ; Thu, 23 Jul 2026 06:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784787919; cv=none; b=s7iTPSyxln02h1m6ZHWLAYgWTDx0fViFc+8th8NA1EQm5VNV/oLefTkkRZS93DRNjliwV8U3fF9aGD5bd3bSZJhMjtrkPnZU4BQesjWiln+b1nZylB7eMuM0CWG8o/yyfZjhEl+cgAj29rSb38vP3uVsmubS7PXt5SOpd2m7THY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784787919; c=relaxed/simple; bh=lR4BrEKUWwFUgV5r/hY0SmpZYAvqTCmveLJxkUYJjco=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LfNXdEaIyNkWZiYOQeJdyb88PVGOjZ4i7x/sp5G/kh0wyyJ4lgCcDhXyUwf7Llzat7904o6kLK+0FcSJCdiCuwxXjP3/ei4fFGyGEKnLBy/0FO24qqTqvzhDWa1CStgQ0IBLA6J+3yJss76/XzR9L+i85aNaJjfw+bx6UN2wn4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=EbSO3bwx; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="EbSO3bwx" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4728c12ba97so99771f8f.0 for ; Wed, 22 Jul 2026 23:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784787915; x=1785392715; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rY35TAUlD5S7ktpUnfbUq2XEBmoTSaPuxjiwa+138dw=; b=EbSO3bwxvI+2nmAxICX4zeRqbAsg2kMl/e2dR3cbMAVLVsPoeguIg8TtU6k8y2Qo+T mdPhKrw1sNBlySFpfgpqejlNKxtnoDAhfzr61hfvB0mFc/wkNCAnloURPSxM1eI0/gB6 N2mnyIlcBRVejMB87U/beyiogkWg8LbHcRvRjGUBJOd63kjTToRqnhatqpDx6KJpwZkW bv/1wY9kKqvFarDvo+pHhuntl5RAC7nIinKoHMIr35dz4Lb7R9PB16yIW82Fa0EX6KXf mBDf34RABR6x0W0KbcSIS5EhrEVONSXArH7mYZghNodTmvxAH34fUT4ROLPdQot417Xm ukMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784787915; x=1785392715; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rY35TAUlD5S7ktpUnfbUq2XEBmoTSaPuxjiwa+138dw=; b=bUfXV+FiMHuzuNrMrIpzYCphevi09icL9ywxSfAQrbX8bMt2xgVVS6v6dpVjUiWse4 9iBx0tHVyFLcHh1YZPDmu4ela8mGTRYqUtn9/026mxxawy9Hw3gvGZID9xsS2c9fXBjx TrfKwR7AYnX6OYmbcCTLRlsQvlG97WD7xyljxR+sU9KNf1rODJ1yh95OtaaZuplq/SFc /yA5v4lNpxHAHVqjZKSOr4Q7J/Wa80wZUzcR2tEYLIYXAKazQTXC2P+f1adcBnJ5mOT+ a5zD56Af3DEAcxguWu0LQg+el8AJF7o7JeHaZFqODk7AIha/rUQ6z9HBxQSI9RkbmcNS CcFw== X-Forwarded-Encrypted: i=1; AHgh+Ro158rKvZ+6qiHZzQZCPa/9co5lTpJt/WxuS+T48wDc4YHPfkfQVVtjOdv7wRcqYG3IEs/7QJ8h6J7H@vger.kernel.org X-Gm-Message-State: AOJu0YyrFSYs98pFHp4WhxhNye3HDuWaL+CXXEXi4jDGrr6O74QyZXwu ebNWtsM4XqcNVKuplslNidXrqmZCzihGFlWCUyVOWlqUQoV16UwELVgIVprHx+bCG04= X-Gm-Gg: AR+sD11cSjwLyIf6czpZ0TekrgTmB+h2ouRhWw69f/wW1hRNSKwcHIC4g5AGjOBzI6m 0oyTVZKX0ZYlZMAcGfZuVtVa0XzpnB27E84xWFtfOpetuRxZlpQNCVcPApelgNkKIlOsL37IcZu btD6cj2cEOSzSzVdKMQz4oQrcxZHfx/dhd1c/cg5D6NpRUD3szfCmT1auV5BaK1daTxHgsAFj+h +1yRKVI6rwV9aYqLt+o0IyfWdln92FiMH1b9lr0Maa6U5tP5KzUvXvVlxjxFmEdDLx/UmamvRAi kzjpAqBHeKnsWHQXvIAgzGNoFrjOewln1p/xUEat9K0PKe6k2OqeWgPtcTkPQvyscULb9Zeflcc dbNzXGSWa9whrCK05htLVi7jStYTBZysasq5gjm9UFKGXVplRI7GmgVqdpSYooU/gMIKSmc/eb4 QbmKeVNan8Gdk8/o/o1w== X-Received: by 2002:a05:6000:46db:b0:47f:91e3:3cbf with SMTP id ffacd0b85a97d-47f91e33d93mr526287f8f.19.1784787915407; Wed, 22 Jul 2026 23:25:15 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85c6f076sm12633187f8f.34.2026.07.22.23.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 23:25:14 -0700 (PDT) Date: Thu, 23 Jul 2026 08:25:13 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Ion Agorria , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v10 2/7] mfd: Add driver for ASUS Transformer embedded controller Message-ID: References: <20260721095233.420823-1-clamor95@gmail.com> <20260721095233.420823-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hohtbe7p7bme7m4a" Content-Disposition: inline In-Reply-To: <20260721095233.420823-3-clamor95@gmail.com> --hohtbe7p7bme7m4a Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v10 2/7] mfd: Add driver for ASUS Transformer embedded controller MIME-Version: 1.0 Hello, On Tue, Jul 21, 2026 at 12:52:28PM +0300, Svyatoslav Ryhel wrote: > From: Micha=C5=82 Miros=C5=82aw >=20 > Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201, > TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock > and TF600T, P1801-T and TF701T pad. This is a glue driver handling > detection and common operations for EC's functions. >=20 > Co-developed-by: Svyatoslav Ryhel > Signed-off-by: Svyatoslav Ryhel > Signed-off-by: Micha=C5=82 Miros=C5=82aw Documentation/process/submitting-patches.rst has: [...] the ordering of Signed-off-by: tags should reflect the chronological history of the patch insofar as possible [...] So your S-o-b should be last when you submit a patch. > +#include > [...] > +#include will go away soon. Please rely on to provide a definition of struct of_device_id and drop the #include of mod_devicetable.h. > +static const struct of_device_id asus_ec_match[] =3D { > + { > + .compatible =3D "asus,sl101-ec-dock", > + .data =3D &asus_ec_sl101_dock_data > + }, { > + .compatible =3D "asus,tf101-ec-dock", > + .data =3D &asus_ec_tf101_dock_data > + }, { > + .compatible =3D "asus,tf201-ec-pad", > + .data =3D &asus_ec_tf201_pad_data > + }, { > + .compatible =3D "asus,tf600t-ec-pad", > + .data =3D &asus_ec_tf600t_pad_data > + }, > + { /* sentinel */ } > +}; Trailing comma after the assignments to .data please. Best regards Uwe --hohtbe7p7bme7m4a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmphs8YACgkQj4D7WH0S /k5hUggAntVLl+JSiaF4SxkXV/Dfehd2NCWtfs+cUwmB6WJFteJP+BcAhhOkk+1E ttUWLQylbkdzFp3xbddXPZWpS5IFjn4vqMbpPOZvtx/sWiA+m4vBqFCozSGwu8/F 9UNUZa3I0cptOeMgAnAVDApboD4tQ3pZlKAF31EzAJnDEz9mFj+5IgedjpVENEeN 5bDcmqTS8xRqlkYuBDphF6wxnp1epbtkJ7knefFwNEqHz/B4ZQc1gtAWgJyIMklZ fasfEq+2cwMArlqDN/bb6iJTIXh9QxBHHuVUqCCHuI4QgEI+QijDdeXmUN56PebB UR+136xjTmkYxJ2dIDxPAY7dj/DVaw== =58oj -----END PGP SIGNATURE----- --hohtbe7p7bme7m4a--