All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/purgatory: Return bool from verify_sha256_digest()
Date: Thu, 23 Jul 2026 09:58:55 +0200	[thread overview]
Message-ID: <amHJv5VB7lL3OvEZ@gmail.com> (raw)
In-Reply-To: <20260722162245.156368-2-thorsten.blum@linux.dev>


* Thorsten Blum <thorsten.blum@linux.dev> wrote:

> -	if (memcmp(digest, purgatory_sha256_digest, sizeof(digest)))
> -		return 1;
> -
> -	return 0;
> +	return memcmp(digest, purgatory_sha256_digest, sizeof(digest)) == 0;

Could you please write this as !memcmp()? The == 0 variant is
quite a bad pattern for such a long line, as it's far easier
to miss during review than a ! unary operator...

Just like here:

> +	if (!verify_sha256_digest()) {

Thanks,

	Ingo

      reply	other threads:[~2026-07-23  7:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 16:22 [PATCH] x86/purgatory: Return bool from verify_sha256_digest() Thorsten Blum
2026-07-23  7:58 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amHJv5VB7lL3OvEZ@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=thorsten.blum@linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.