From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0AE4C531C7 for ; Thu, 23 Jul 2026 09:28:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wmpj9-00042C-M3; Thu, 23 Jul 2026 05:28:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wmpj8-00041n-3i for qemu-devel@nongnu.org; Thu, 23 Jul 2026 05:28:26 -0400 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wmpj6-0006XQ-Rg for qemu-devel@nongnu.org; Thu, 23 Jul 2026 05:28:25 -0400 Received: from linux.microsoft.com (unknown [167.220.196.63]) by linux.microsoft.com (Postfix) with ESMTPSA id 44BDF20B7167; Thu, 23 Jul 2026 02:28:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 44BDF20B7167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1784798890; bh=/wSBCRKU/EQhWR7uOBKd/KEVsp0s4887FPUQa5ML1ZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZducHQWpJ0FrTh58bekejuTFqGyp5PycLqHcvbjw6v1QPlaEkxT59775b/Z6fS2mj 0E7uE8TFYyYot8c7yx+KJ/edkg3CaQx9pSmSYmJZUIS0kXyGl+PihbYNjsjtsykO+D hZm/O5zRSYKwfoMzyVINR5yUpP1n4+SHaAvWCKq0= Date: Thu, 23 Jul 2026 12:28:17 +0300 From: Doru =?iso-8859-1?Q?Bl=E2nzeanu?= To: Magnus Kulke Cc: qemu-devel@nongnu.org, Paolo Bonzini , Zhao Liu , Richard Henderson , Magnus Kulke , "Michael S. Tsirkin" , Wei Liu , Doru =?iso-8859-1?Q?Bl=E2nzeanu?= , Wei Liu Subject: Re: [PATCH 12/12] hw/i386/mshv: drop initial msi vector 0 Message-ID: References: <20260710101534.664604-1-magnuskulke@linux.microsoft.com> <20260710101534.664604-13-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260710101534.664604-13-magnuskulke@linux.microsoft.com> Received-SPF: pass client-ip=13.77.154.182; envelope-from=dblanzeanu@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jul 10, 2026 at 12:15:34PM +0200, Magnus Kulke wrote: > This has been a warning before that was always raised if the machine has > a hpet. hpet_reset() will eventually result in mshv_send_msi called w/ > vector 0, which we can safely drop. > > Signed-off-by: Magnus Kulke > --- > hw/i386/mshv/apic.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/i386/mshv/apic.c b/hw/i386/mshv/apic.c > index 9188a93b2f..ad326030bf 100644 > --- a/hw/i386/mshv/apic.c > +++ b/hw/i386/mshv/apic.c > @@ -293,6 +293,16 @@ static void mshv_send_msi(MSIMessage *msi) > delivery = (data >> MSI_DATA_DELIVERY_MODE_SHIFT) & > MSI_DATA_DELIVERY_MODE_MASK; > > + /* > + * Vector 0 is not a valid interrupt vector (0-15 are reserved for CPU > + * exceptions). This can trigger during machine reset, if hpet_reset() > + * forces the PIT to pulse GSI 2 before IOAPIC's own reset has masked its > + * redirection entries. > + */ > + if (vector == 0) { > + return; > + } > + > mshv_request_interrupt(mshv_state, delivery, vector, dest, dest_mode, > trigger_mode); > } > -- > 2.34.1 Reviewed-by: Doru Blânzeanu