From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25DF8C531D2 for ; Thu, 23 Jul 2026 12:55:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wmswf-0004tp-43; Thu, 23 Jul 2026 08:54:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wmswS-0004hC-8D for qemu-devel@nongnu.org; Thu, 23 Jul 2026 08:54:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wmswN-0002EG-GV for qemu-devel@nongnu.org; Thu, 23 Jul 2026 08:54:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784811257; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OhnukckyjUTtZRplsRD3KUYOcApispTBtT9cuXI06RQ=; b=PatkVhOYAZBCUy2ldyywIfz1jalw9I/anBG8B42carCFRRr2cvFxKzX+AzeK+Rk0s1D2PA TyhSBroPmiYzHVQeq/38NlSQp4ip7LSarfIYckY4kFqwlcTtyDaONP5XVSHNLe5nE1PURH lPYawZAfOx8rWVShITtzOo7bCEcxv1g= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-6vTOhhfGMJyN4DXmtOgCwQ-1; Thu, 23 Jul 2026 08:54:13 -0400 X-MC-Unique: 6vTOhhfGMJyN4DXmtOgCwQ-1 X-Mimecast-MFC-AGG-ID: 6vTOhhfGMJyN4DXmtOgCwQ_1784811252 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3D5D1945CAA; Thu, 23 Jul 2026 12:54:11 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.196]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A26C7180034C; Thu, 23 Jul 2026 12:54:06 +0000 (UTC) Date: Thu, 23 Jul 2026 13:54:02 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jamin Lin Cc: =?utf-8?Q?C=C3=A9dric?= Le Goater , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Eric Blake , Markus Armbruster , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:All patches CC here" , "open list:ASPEED BMCs" , Troy Lee Subject: Re: [PATCH v2 12/17] tests/unit/test-crypto-cipher: Test AES-GCM mode Message-ID: References: <20260715033311.1648424-1-jamin_lin@aspeedtech.com> <20260715033311.1648424-13-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260715033311.1648424-13-jamin_lin@aspeedtech.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: permerror client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.951, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jul 15, 2026 at 03:33:32AM +0000, Jamin Lin wrote: > Exercise the new GCM mode and the setaad/gettag helpers with the > canonical AES-GCM test vectors from the GCM specification (McGrew & > Viega, also NIST SP 800-38D): AES-128 and AES-256, with and without > associated data. Each vector is run through encrypt (checking the > ciphertext and the generated tag) and decrypt (checking the recovered > plaintext and the recomputed tag). > > Signed-off-by: Jamin Lin > --- > tests/unit/test-crypto-cipher.c | 240 ++++++++++++++++++++++++++++++++ > 1 file changed, 240 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|