All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Miao, Jun" <jun.miao@intel.com>
Cc: "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
	"Huang, Kai" <kai.huang@intel.com>,
	"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"Du, Fan" <fan.du@intel.com>, "x86@kernel.org" <x86@kernel.org>,
	"challvy.tee@gmail.com" <challvy.tee@gmail.com>
Subject: Re: [PATCH v5] x86/sgx: Report RCU-Tasks quiescent state in EPC sanitization loop
Date: Thu, 23 Jul 2026 16:03:52 +0300	[thread overview]
Message-ID: <amIROIRvs_bmaoh9@kernel.org> (raw)
In-Reply-To: <PH7PR11MB84559DCC54D746868A3424D39AC02@PH7PR11MB8455.namprd11.prod.outlook.com>

On Thu, Jul 23, 2026 at 09:57:33AM +0000, Miao, Jun wrote:
> >You should probably also say why cond_resched() does not trigger
> >rescheduling. E.g., put that and delete the first sentence as it tells nothing
> >and is confusing.
> 
> Hi BR, Jarkko,
> 
> How about I place the explanation as a comment above the code at the v6 version ?
> See the description below.
> 
> Warm regards
> Jun Miao

Yeah, that is exactly kind of reminder that would make sense there.

> 
> >> --- a/arch/x86/kernel/cpu/sgx/main.c
> >> +++ b/arch/x86/kernel/cpu/sgx/main.c
> >> -		cond_resched();
> +               /*
> +                * cond_resched() only schedules when TIF_NEED_RESCHED is set.
> +                * During this boot-time loop that condition may not happen for a
> +                * long time, so report an RCU-Tasks quiescent state explicitly.
> +                */
> 
> >> +		cond_resched_tasks_rcu_qs();
> >>  	}
> >>
> >>  	list_splice(&dirty, dirty_page_list);
> >> --
> >> 2.32.0
> >>
> >
> >

BR, Jarkko

      reply	other threads:[~2026-07-23 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  8:48 [PATCH v5] x86/sgx: Report RCU-Tasks quiescent state in EPC sanitization loop Jun Miao
2026-07-03  9:00 ` sashiko-bot
2026-07-09 13:24 ` Jarkko Sakkinen
2026-07-23  9:57   ` Miao, Jun
2026-07-23 13:03     ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amIROIRvs_bmaoh9@kernel.org \
    --to=jarkko@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=challvy.tee@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fan.du@intel.com \
    --cc=hpa@zytor.com \
    --cc=jun.miao@intel.com \
    --cc=kai.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.