From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <andrealmeid@igalia.com>,
<christian.koenig@amd.com>, <airlied@gmail.com>,
<simona.vetter@ffwll.ch>, <mripard@kernel.org>,
<maarten.lankhorst@linux.intel.com>, <tzimmermann@suse.de>,
<anshuman.gupta@intel.com>, <badal.nilawar@intel.com>,
<riana.tauro@intel.com>, <karthik.poosa@intel.com>,
<sk.anirban@intel.com>
Subject: Re: [PATCH v11 0/3] Introduce cold reset recovery method
Date: Thu, 23 Jul 2026 10:03:27 -0400 [thread overview]
Message-ID: <amIfL_ZS7HamPImW@intel.com> (raw)
In-Reply-To: <amHzsHmNSH84SZ92@black.igk.intel.com>
On Thu, Jul 23, 2026 at 12:57:52PM +0200, Raag Jadav wrote:
> On Mon, Jul 20, 2026 at 03:48:16PM +0530, Mallesh Koujalagi wrote:
> > Add support for handling errors that require a complete
> > device power cycle (cold reset) to recover.
> >
> > Certain error conditions leave the device in a persistent hardware
> > error state that cannot be cleared through existing recovery mechanisms
> > such as driver reload or PCIe reset. In these cases, functionality can
> > only be restored by performing a cold reset.
> >
> > To support this, the series introduces a new DRM wedging recovery
> > method, DRM_WEDGE_RECOVERY_COLD_RESET (BIT(4)). When a device is wedged
> > with this method, the DRM core notifies userspace via a uevent that a cold
> > reset is required. This allows userspace to take appropriate action to
> > power-cycle the device.
>
> This one looks like to good to go.
I don't think so. Sashiko had identified that this path of cold reset
won't be actually reached in the probe. I asked the introduction
of a fault-inject test case so we can ensure that we do hit this case.
>
> Chris? André? Can you please help review so we can merge it?
That aside, after we ensure the path is hit, we want to keep this
cold reset one.
So, the ack is already welcomed and needed.
Thanks,
Rodrigo.
>
> Raag
prev parent reply other threads:[~2026-07-23 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 10:18 [PATCH v11 0/3] Introduce cold reset recovery method Mallesh Koujalagi
2026-07-20 10:18 ` [PATCH v11 1/3] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET " Mallesh Koujalagi
2026-07-20 10:30 ` sashiko-bot
2026-07-20 10:18 ` [PATCH v11 2/3] drm/doc: Document " Mallesh Koujalagi
2026-07-20 10:18 ` [PATCH v11 3/3] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-07-20 10:48 ` sashiko-bot
2026-07-21 17:37 ` Rodrigo Vivi
2026-07-20 14:30 ` ✓ CI.KUnit: success for Introduce cold reset recovery method (rev11) Patchwork
2026-07-20 15:05 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-20 19:09 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-23 10:57 ` [PATCH v11 0/3] Introduce cold reset recovery method Raag Jadav
2026-07-23 14:03 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIfL_ZS7HamPImW@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=mripard@kernel.org \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=sk.anirban@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.