From: Segher Boessenkool <segher@kernel.crashing.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: "Markus Elfring" <Markus.Elfring@web.de>,
acpica-devel@lists.linux.dev, bpf@vger.kernel.org,
coresight@lists.linaro.org, kvm@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, linux-perf-users@vger.kernel.org,
linux-pm@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, mptcp@lists.linux.dev,
netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org,
virtualization@lists.linux.dev,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Alex Mastro" <amastro@fb.com>,
"Alex Williamson" <alex@shazbot.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Ankur Arora" <ankur.a.arora@oracle.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Bobby Eshleman" <bobbyeshleman@meta.com>,
"Christian Bornträger" <borntraeger@linux.ibm.com>,
"Christophe Leroy" <chleroy@kernel.org>,
"Chun-Tse Shao" <ctshao@google.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Costa Shulyupin" <costa.shul@redhat.com>,
"Crystal Wood" <crwood@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"David Hildenbrand" <david@kernel.org>,
"David Matlack" <dmatlack@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Eric Dumazet" <edumazet@google.com>,
"Gabriele Monaco" <gmonaco@redhat.com>,
"Geliang Tang" <geliang@kernel.org>,
"Ian Rogers" <irogers@google.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Ivan Pravdin" <ipravdin.official@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Jason Xing" <kerneljasonxing@gmail.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Joe Damato" <joe@dama.to>,
"John Garry" <john.g.garry@oracle.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Kaushlendra Kumar" <kaushlendra.kumar@intel.com>,
"Kent Gibson" <warthog618@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Len Brown" <lenb@kernel.org>, "Leo Yan" <leo.yan@linux.dev>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mat Martineau" <martineau@kernel.org>,
"Matthieu Baerts" <matttbe@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Mike Leach" <mike.leach@arm.com>,
"Mina Almasry" <almasrymina@google.com>,
"Mykyta Yatsenko" <yatsenko@meta.com>,
"Nam Cao" <namcao@linutronix.de>,
"Namhyung Kim" <namhyung@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Pawel Chmielewski" <pawel.chmielewski@intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Quentin Monnet" <qmo@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Raghavendra Rao Ananta" <rananta@google.com>,
"Saket Dumbre" <saket.dumbre@intel.com>,
"Shuah Khan" <shuah@kernel.org>,
"Simon Horman" <horms@kernel.org>, "Song Liu" <song@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Tomas Glozar" <tglozar@redhat.com>,
"Vipin Sharma" <vipinsh@google.com>,
"Wander Lairson Costa" <wander@redhat.com>,
"Will Deacon" <will@kernel.org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Willy Tarreau" <w@1wt.eu>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Zhang Chujun" <zhangchujun@cmss.chinamobile.com>,
"Zhang Rui" <rui.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tools: Use fputc() calls in some functions
Date: Thu, 23 Jul 2026 10:14:12 -0500 [thread overview]
Message-ID: <amIvxECTIM5paT94@gate> (raw)
In-Reply-To: <amIbVOIsOeZgcBZF@tassilo>
On Thu, Jul 23, 2026 at 06:47:00AM -0700, Andi Kleen wrote:
> On Thu, Jul 23, 2026 at 12:25:25PM +0200, Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 23 Jul 2026 11:13:30 +0200
> > Subject: [PATCH] tools: Use fputc() calls in some functions
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > Single characters should occasionally be transferred into the output.
> > Thus use the corresponding function “fputc” (or even “putchar”).
> >
> > The source code was transformed by using the Coccinelle software.
>
> gcc already does this transformation automatically.
Yup. And the printf() form is much more regular, expected, readable.
The primary consumers of source code are human beings, all programs
should be written with that in mind!
Segher
next prev parent reply other threads:[~2026-07-23 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 10:25 [PATCH] tools: Use fputc() calls in some functions Markus Elfring
2026-07-23 13:47 ` Andi Kleen
2026-07-23 14:33 ` Steven Rostedt
2026-07-23 15:14 ` Segher Boessenkool [this message]
2026-07-23 15:07 ` bot+bpf-ci
2026-07-23 15:07 ` bot+bpf-ci
2026-07-23 15:07 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIvxECTIM5paT94@gate \
--to=segher@kernel.crashing.org \
--cc=Markus.Elfring@web.de \
--cc=acme@kernel.org \
--cc=acpica-devel@lists.linux.dev \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex@shazbot.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=almasrymina@google.com \
--cc=amastro@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ankur.a.arora@oracle.com \
--cc=ast@kernel.org \
--cc=bobbyeshleman@meta.com \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=brgl@kernel.org \
--cc=chleroy@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=costa.shul@redhat.com \
--cc=crwood@redhat.com \
--cc=ctshao@google.com \
--cc=daniel.lezcano@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=dmatlack@google.com \
--cc=donald.hunter@gmail.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=emil@etsalapatis.com \
--cc=frankja@linux.ibm.com \
--cc=geliang@kernel.org \
--cc=gmonaco@redhat.com \
--cc=horms@kernel.org \
--cc=imbrenda@linux.ibm.com \
--cc=ipravdin.official@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=joe@dama.to \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kaushlendra.kumar@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukasz.luba@arm.com \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=memxor@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mptcp@lists.linux.dev \
--cc=namcao@linutronix.de \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=pawel.chmielewski@intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qmo@kernel.org \
--cc=rafael@kernel.org \
--cc=rananta@google.com \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=saket.dumbre@intel.com \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=suzuki.poulose@arm.com \
--cc=swapnil.sapkal@amd.com \
--cc=tglozar@redhat.com \
--cc=vipinsh@google.com \
--cc=virtualization@lists.linux.dev \
--cc=w@1wt.eu \
--cc=wander@redhat.com \
--cc=warthog618@gmail.com \
--cc=will@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
--cc=zhangchujun@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.