Re: [PATCH] hw/sd/sdcard: Register device ops in drives without media

[Alberto Garcia <berto@igalia.com>]

On Thu, Jul 23, 2026 at 10:58:39PM +0200, Alberto Garcia wrote:
> -    if (blk_size >= 0) {
> -        blk_size -= sd->boot_part_size * 2 + sd->rpmb_part_size;
> -        if (blk_size > SDSC_MAX_CAPACITY) {
> -            if (sd_is_emmc(sd) &&
[...]
> +        int64_t blk_size = blk_getlength(sd->blk);
> +        if (blk_size >= 0) {
> +            blk_size -= sd->boot_part_size * 2 + sd->rpmb_part_size;
> +            if (blk_size > SDSC_MAX_CAPACITY) {
> +                if (sd_is_emmc(sd) &&
[...]

There's a bit of churn here because I'm moving a whole block inside
another one, because I think that the resulting code reads better, but
we can of course keep the patch simpler if you prefer:

@@ -3145,7 +3145,9 @@ static void sd_realize(DeviceState *dev, Error **errp)
             error_setg(errp, "eMMC image smaller than boot partitions");
             return;
         }
+    }
 
+    if (sd->blk) {
         ret = blk_set_perm(sd->blk, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE,
                            BLK_PERM_ALL, errp);
         if (ret < 0) {

Berto