From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662013385B6 for ; Fri, 24 Jul 2026 03:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784863472; cv=none; b=Xujdk6uTJcB0KT74hGg2GjMUBQ34ugPryKAP9PkPsrYt3By8Asq19FVboXnD7aO3kYi+8Mrhqhkih1gEcCEW8InPA7qWOgHMHZSlpsrp6p6K82JmjSa0A2d5qwZ4w5CULIegPc5h1kBhlBM8aOtTsZb6kUwwXaDzk1oRUdcLG9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784863472; c=relaxed/simple; bh=rgjOfO4aPyc2lcOdqawmMnLupom2yPe5T+CEQOfc8NM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PxBSkVkWWWxRhfxOKTvsFgIq+kE5eENq75qUTgasDsoXJgLK42Zuvij9KAYdluFNYMdo60n0FeMG8XbYXyXo5tgtYJ5eKWdTbKgXArfiVjL20+NDRIDLrbCXs9+/TWt9dSJkn57MA42H6GOpFukFsoqNUjnER3NHG/1Qen1kwlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QCtEACXi; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QCtEACXi" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84847482584so853621b3a.0 for ; Thu, 23 Jul 2026 20:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784863471; x=1785468271; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hm9oIj1K1tgewTs09Ec3mlyW7LXuMO/BD5Jfkqnoqbw=; b=QCtEACXin+GIK6M2U4+KxobGqs/yGZHUEg6d++PDhm8Rc0QOmZcZCWgPyiUd07LScF 7C2kKwi2AJurKLCoSkCxINPSsiwrRXu/0o0N6pJ4E0UoBGsm0ogXkxplhBiDtmSQhTRK 0pCPdxHxOuNNDQV5W6PfKycSMb/mKl81V2ITs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784863471; x=1785468271; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hm9oIj1K1tgewTs09Ec3mlyW7LXuMO/BD5Jfkqnoqbw=; b=U0Xt01H+zZjYkq1fwebm/ksA+rxg6fHIY/OZAc+vbs+0SibmoQY/8iUaeF6rY51/m0 bXx+K6nBnq5Yt+qZHp2196EnMpYl4lLDBeggu12K6CUVlcOSrpvZleyiJ7x9Nl4JeH0B fUcRaGJMullsJUtXXr7yJbFL1QBIaQBygVdw6ljTimrMK0Pl2M2+H/Vmc09a+j0U56BE wJnl5NuspkhLjn9YopRNgyCzvW1g95Eq5Wy0GrX+/r+lZVMFKmk45lnVEi4f6NzBious 40bESAu1n1vLZeGzsaHPcqBHC6BcmrGnyQ0dnVAs9CD69q+n44cQw5GSHC4WsX59oabF l4MQ== X-Forwarded-Encrypted: i=1; AHgh+Rpqn/ULr9i++N6WqS5hYPC1gKeKgEZd1Nbyh8ThePQz6j7plTt3LN/q5CcX/Xcabaus2UW1fb0/q7QR/7M=@vger.kernel.org X-Gm-Message-State: AOJu0YwnO3TB5UAYKif9ycOITcdrA8qOLMMeskZYIHB6BHn67qxrAX6V 07C47N7UFG046xBKbVmI5FTVYAhVeWhrtMNzGT5hTn+eIwU9Lyhw9FI6by2MWWsbeLoSEYoLiFA +mX0= X-Gm-Gg: AR+sD11beSixbvrcBbNrQXd1vPZ0+4QCtO8Ntd1fJHBS72gYctVSfaYhSPZnl0oFDyK 4MzuysjXukN2YRvGmv10zHVjXrCphPiXt7xP6e4cj2qMgbCGZvstqm6TPtfKkdB3F02Ji50f69j kYhxZL61pHStV5fVE3kGPUxqA9SvC8sT7A+BOALP2E6+Vv2H8sRS5TNjQuCLJBLN1BZFIoAC/qj YSZsRWBB8vDiw19BHeDRPUMDipwn7HDOYhn18JAa028u7sv/rashPOo3GyuOF/yyWuZsjCNv4ug Mfpgz7h9tDk2fGwlY2RvM/oQa3cSxcma9sDhaFl/kET+DMOb0UIjctT61tid0yosbTEBJUVGcbJ A+vbn/x5/ei1a9oO/4JnBDnX1/1voz1Q2aEZKxObBNkFI4FQ8XnvxYIgwlaC+vvxNxDzZX2N7Vg HrmETcGM6z3jWFwtNVShT1ygHkSDAmyrtCBQ9cwLgDNA== X-Received: by 2002:a05:6a00:4f90:b0:847:7cf2:a8ff with SMTP id d2e1a72fcca58-84e2e957966mr5971433b3a.30.1784863470651; Thu, 23 Jul 2026 20:24:30 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:c102:f12d:5168:6be5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e175f31b3sm4001385b3a.54.2026.07.23.20.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 20:24:30 -0700 (PDT) Date: Fri, 24 Jul 2026 12:24:26 +0900 From: Sergey Senozhatsky To: Sebastian Andrzej Siewior Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Minchan Kim , Sergey Senozhatsky , Jens Axboe Subject: Re: [PATCH 2/2] zram: Use a custom key for each zram object. Message-ID: References: <20260714141300.3945672-1-bigeasy@linutronix.de> <20260714141300.3945672-3-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714141300.3945672-3-bigeasy@linutronix.de> Hello, sorry for the delay On (26/07/14 16:13), Sebastian Andrzej Siewior wrote: > Each struct zram uses the same key for its struct lockdep_map which is > used for locking analysis. > According to Sergey the lock chains might be different if zram1 is used > for and zram2 is for ext4. This might lead to false dead lock reports if ^^ swap (a minor nit) > it mixes a zram1 chain with a zram2. This can be avoided if each lockmap > gets its own unique key.c > > Use a dynamic lock_class_key for the table_lock_map. > [..] > static bool zram_meta_alloc(struct zram *zram, u64 disksize) > @@ -1999,7 +1993,8 @@ static bool zram_meta_alloc(struct zram *zram, u64 disksize) > if (!huge_class_size) > huge_class_size = zs_huge_class_size(zram->mem_pool); > > - slot_lock_init(zram); > + lockdep_register_key(&zram->table_lock_key); > + lockdep_init_map(&zram->table_lock_map, "zram->table[index].lock", &zram->table_lock_key, 0); So I wonder if we can give distinct name, given that it's per-device now: "zram%d->table[index].lock" and use zram->disk->first_minor (which is a unique device id). If you are too busy I can just send a trivial follow up patch. Let me know what you prefer. Reviewed-by: Sergey Senozhatsky Tested-by: Sergey Senozhatsky