From: Vincent Jardin <vjardin@free.fr>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver
Date: Fri, 24 Jul 2026 12:18:08 +0200 [thread overview]
Message-ID: <amM74M7myX2tJXMQ@L30177.local> (raw)
In-Reply-To: <6abbdabe-91ec-4757-a646-8b2b2d4058d3@roeck-us.net>
Hi Guenter,
> > + for (i = 0; i < ARRAY_SIZE(mpq8646_alarm_map); i++) {
> > + if (newly_set & mpq8646_alarm_map[i].mask)
> > + hwmon_notify_event(priv->hwmon_dev,
> > + mpq8646_alarm_map[i].type,
> > + mpq8646_alarm_map[i].attr,
> > + mpq8646_alarm_map[i].channel);
>
> This is wrong. This will require a new exported notification function
> in pmbus code.
OK, next, I'll try to factor the body of pmbus_fault_handler() into
an exported helper, something like pmbus_check_and_notify_faults(client).
It should help to revisit it.
Best regards,
Vincent
prev parent reply other threads:[~2026-07-24 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 23:55 [PATCH v5 0/3] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-23 23:55 ` Vincent Jardin
2026-07-23 23:55 ` [PATCH v5 1/3] hwmon: pmbus: event notification with alarms Vincent Jardin via B4 Relay
2026-07-23 23:55 ` Vincent Jardin
2026-07-24 0:10 ` sashiko-bot
2026-07-23 23:55 ` [PATCH v5 2/3] dt-bindings: hwmon: pmbus: add MPS MPQ8646 binding Vincent Jardin via B4 Relay
2026-07-23 23:55 ` Vincent Jardin
2026-07-24 0:02 ` sashiko-bot
2026-07-23 23:55 ` [PATCH v5 3/3] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-23 23:55 ` Vincent Jardin
2026-07-24 0:06 ` sashiko-bot
2026-07-24 2:07 ` Guenter Roeck
2026-07-24 10:04 ` Vincent Jardin
2026-07-24 2:15 ` Guenter Roeck
2026-07-24 10:18 ` Vincent Jardin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amM74M7myX2tJXMQ@L30177.local \
--to=vjardin@free.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.