From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C42A3630B0 for ; Fri, 24 Jul 2026 15:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908526; cv=none; b=Qd9qNv0+24QMEDUmJFi+gmxhal3HTQTdM1NZ9I6ijEFv+D5tLM7jHzQ8V9/Om7joRLRlX8IES+KOamf1wN6m8mCplPwQgyBJR4QXEz9c6HLfgS25u7MmxE2kk2mjsUDoLsCxa3d0Agd90+4f615ATbkBydQ3HgQXFftNT3V0aYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908526; c=relaxed/simple; bh=JhbTbs0FOdbvKTC2L6+5hjqopjEb9VhxHqIQKPO/IAE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ESPS9hJEdP+rwMorLq/Tny7Qi9RlqkTNrMkcrm4p3X2tviDyfmRj+KVLo5cYzmhMjz/LzF7Hv2NaICIS67j3eZFMWZwPH2FjZmRgi/ToOJy2SblcYW/kccI/4EhhtwxfdMbgB2LNtARmGk9peGuYLkUPae6lPqroybvygRiOlB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aEJhwT1Q; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NtcYu0q3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aEJhwT1Q"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NtcYu0q3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784908523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aWD66a2ehIm/e4HyZcO15kOI/PXJYRp804FM2jJzuJM=; b=aEJhwT1QJBvCpsFI9Xk44hB78JvcyITxi/1vnEvWtd3UlE5ZvyuA0orXvdBPSkmrm3joS6 zrCW0c6h8dOduG5749+0E2o8G1zf0tGdBtZ0Ow8L/Rln3+drfikIJCWqXbhqkcXnnn0qa5 GS81Q5vwHjn5OhXgEyZdjFwOBMWhjfs= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-OFpdr6QkMa25I1mUfYln5w-1; Fri, 24 Jul 2026 11:55:22 -0400 X-MC-Unique: OFpdr6QkMa25I1mUfYln5w-1 X-Mimecast-MFC-AGG-ID: OFpdr6QkMa25I1mUfYln5w_1784908522 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5174a23afcbso6426131cf.3 for ; Fri, 24 Jul 2026 08:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784908522; x=1785513322; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=aWD66a2ehIm/e4HyZcO15kOI/PXJYRp804FM2jJzuJM=; b=NtcYu0q3gtPFzO0aIqg8kMrC3Oly67xUPxCdDkpiALicGk8Go2Y9yVgH6v7/9l1yvc riOU8BW0vjJ9M1hRhfm3qurzHvh21/oaA9pRvi26ckBRxhvxBg7TyE9whbsh9w1/U/XI Dgz5XrKpZSni+c0RyLrKcnz7yx4XImCv5unEIE6q3hgwLffbLFXLZE5VOYZTD+V0KSfD MGM2iQui2rSIL7+uRDOEZaq57Ug5eE6xxth3fRHb/ASQf6/d6yVOKsi9qQg5QJJW+7e4 7JTMJuPgXqoeE/M3rF+YPT8JZSgkRpEfHDZJxI4Vd5wsQIzD6wJeS1gokbL4xkdeIw/4 5EXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784908522; x=1785513322; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aWD66a2ehIm/e4HyZcO15kOI/PXJYRp804FM2jJzuJM=; b=hx8hKxqItRRC3WYAb/VVB2xH5aiqjAXIGMx9mjVsvPPe5SGsV6CX+MOOp9FglgdA8r IMM6XxTKgumKll3Q5qPZ3HbRBbqKRGYHoSWz4BG5oCJAWi7Na6n1ChZI8x4Y3Lk51byg blFoU5N6PwtAtnNpurepc9NfrYfiSezT3QJRoeldroobbOeqCOAJBjwT+RZa2xhO0iYj nTF+MwCpjd4IEgqR6LVoYluHvL5P/Twd6iZ/WPbilaLCd95Afe5nQmZj18WKYWe5K+WZ 7jwwnh/oUJ47ZgEH9akbxbpUuGQjQaY0AAIVfUGk8HPl7r7FUlMR8EYFaBZnyW3OuA0A UGYw== X-Forwarded-Encrypted: i=1; AHgh+Roc1uRuM1lumg//G5srvBinvHZdMv3dl3XPYyfkB0tXzvYAJ/uayyIb5SuUncq6K2DQzX4WAD3jR9dqBtE=@vger.kernel.org X-Gm-Message-State: AOJu0YzrOAsmmVQroyaF9N+vIsAXc2Wc46WiOhjZ2hLxQrih0DKcIqNW ZaOeuxoQ5MQt/GAaLQywYEawTkORHdwPi5xdUxt1BgVdZ3ZETeGMAJw1rH549ib7PJRD24M8xek 8IHMftMN+p9c89qMKPYsOlnurykZWk5zaOwMnj4o97c+jHABbvKckyPLIucruIqRHRw== X-Gm-Gg: AR+sD11jw+EH02pAq/j47YFmArblH/4AAY6PmhAod8AngfErMjJOwSwlZYTzWXYrcPz 3k4DQ8MulSQ+Vomq/iICjwVbhhFnUkG7BantpwmGn+NUHbjH3zBqF4yPy5ciWt8Zqq7sxd6qFvP 9smcbVF7HpYJMAccv9n7lsq0BMeYs8LkaLIh10zfw1dqjdV2RSzZI/b+fF5nrxZoonqkOn5MrEs S9WKWlWk6VpICQYlSjKEmCGNKD/aJBCCHBKICLIJAOdfIn8agEsBPP19jRHdZNnOwVBuvp6+aKM Cp7iIELlYWSm8ytZzHnSlaQ7d0iCln1tt1gN8kU1NvFvnZW2FTVrM3bxgVRv+DxwoSS+lBlaaKc 42XlMRcTXdjOhk5xaKtd3v0cB/7ZnP3r73Z4= X-Received: by 2002:a05:622a:164d:b0:51c:25da:903f with SMTP id d75a77b69052e-5283df3a21fmr79139741cf.59.1784908522038; Fri, 24 Jul 2026 08:55:22 -0700 (PDT) X-Received: by 2002:a05:622a:164d:b0:51c:25da:903f with SMTP id d75a77b69052e-5283df3a21fmr79139341cf.59.1784908521604; Fri, 24 Jul 2026 08:55:21 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a27f4346sm2307631cf.8.2026.07.24.08.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 08:55:21 -0700 (PDT) Date: Fri, 24 Jul 2026 11:55:18 -0400 From: Brian Masney To: Mathieu Dubois-Briand Cc: Tero Kristo , Michael Turquette , Stephen Boyd , Tony Lindgren , Thomas Petazzoni , =?iso-8859-1?Q?Th=E9o?= Lebrun , =?iso-8859-1?Q?Gr=E9gory?= Clement , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: ti: mux: resolve parent clocks by DT index, not by name Message-ID: References: <20260715-mathieu-wdt-clock-theo-v1-1-da65bba1828b@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) Hi Mathieu, On Fri, Jul 24, 2026 at 04:56:01PM +0200, Mathieu Dubois-Briand wrote: > On Thu Jul 16, 2026 at 7:49 PM CEST, Brian Masney wrote: > > On Wed, Jul 15, 2026 at 05:09:56PM +0200, Mathieu Dubois-Briand wrote: > >> Resolve parent clocks by their index into the device tree "clocks" > >> property rather than matching names as strings. Name-based matching is > >> fragile because a clock's "clock-output-names" value in its provider > >> node can differ from the name used to reference it in a consumer node, > >> and because names must be globally unique across all clock providers. > >> > >> On AM335x, this caused broken clock trees where some clocks failed to > >> enable because their parents could not be found. > >> > >> Replace of_clk_parent_fill() with a clk_parent_data array that sets > >> .index to the array position. > >> > >> Fixes: ec7aa25fa483 ("ARM: dts: Use clock-output-names for am3") > >> Signed-off-by: Mathieu Dubois-Briand > > > > So this only updates of_mux_clk_setup(). of_ti_composite_mux_clk_setup() > > calls ti_clk_add_component(), which does a name based matching as well. > > It would be nice to have this consistent within the same driver. I know > > this is going to require a larger refactor. > > > > Otherwise your fix looks correct to me. > > > > Brian > > Hi Brian, > > Thanks for your comment. > > Yes, it does make sense to make everything consistent here. I'm not > really comfortable with this driver, but I can give it a try. > > Just to be sure, are you talking only about drivers/clk/ti/composite.c > or is it about more files in drivers/clk/ti/? I'm not sure to understand > the whole interactions between each components here. > > Fixing drivers/clk/ti/composite.c to use clk_parent_data looks easy, I > can definitely send a patch for that. But you are talking about a larger > refactor, so I suspect you would like to see more changes. I think we should just get drivers/clk/ti/composite.c consistent with itself. Brian