From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1B3484236 for ; Fri, 24 Jul 2026 23:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784937585; cv=none; b=vBw3crI5pfocYjxwuCxwbA4CJY8JY+RowTU1+wkBlLRiqNZ7RAVONFd+dYl3gH9CNZu5gFUGzrtFPHnTj//eEG8kV9zmBl8Q0oIM/rYCVfp5PJdM7Gpnb01DjoFGzR1Gbt1En6/vD8AK2dR9yTzcaW4N3vRHlJluVxMISXfmC/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784937585; c=relaxed/simple; bh=6g2P92LnSTMEc9u55dS6d7CPcAA1BZpmHmRQqM9EJFg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KBHbYhiXp4/NSMLJmzIvY3ulT12z2+KiFh8WjM7OTlLgKio3gu+m4QowjJ8El9fggjv1jquWsx48v0e9h2R8gt8/qaZd/VnCOvfR7/n+JTbSfLl6ik/P4oCJOSX24A2zeubObxzn9Cz+IDkACp5xIauXGU9ly3vtIGXoz2t3Efw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qb71Keu2; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qb71Keu2" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-383cb94f742so941553a91.3 for ; Fri, 24 Jul 2026 16:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784937583; x=1785542383; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6kHpr2vY/Ca1GMVlUGShPHXsBqctbPxNgTkcfcAefXA=; b=qb71Keu2OjIdE8mba2yOV7oDbwGSAvNJvXI8Mcu8rLth+UiT/7sX07UitAnsS89SEW +t/Twr79IxF/uZX0378rFs0Mo3feqgxw7scc1bmMzKULI0nZda7YH9++E0Lp91tIeSrv Ls5JRjxN84JAdHYdLhNNWj9Al5k/anMrFHJ4ZQ5S5xgz/4r1qc8gtXBYwv5Cp+FkwD6L 1Mv8/zXeZK9FupBzejt67p4xMCDn3xTlaNCJzmhOwxxo+wCwT9VbAucYxwW8kJkZg2Uq 5DQjNuuO47zaBTEhkpIsJgigjanNcVX9VULFY7ST3DwP2lhnd92MHvnB2VlbwF+8YPH0 P+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784937583; x=1785542383; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6kHpr2vY/Ca1GMVlUGShPHXsBqctbPxNgTkcfcAefXA=; b=sAmwsl4oiNf/HZ1vmLqS0sv+ztguv7qeQVwrhw6mAJxR9+nFZPTI29ncaIE2m6IlFf 1pU017iJGzzFQ48YoqwQdbQyTMmaWBM7LFZGoVQG8gip0Xm3l8MQggDOZmf+cPemab6W Ns0Ofp0qrgdNWG8PuI7P+5JYAT58iN9Vf/xxzra7sUgsBxtSHP8LJZF6xpm+qnGNKtuj k+vA8V7h1djfEF1wYA6jLvpK6nE8VV25qy4/XiGMt8jgaMS7FWnb102HVY927fOxWQzZ aQUqOn3CYr/mRwubnY2V7nMWlAQjUzqSJHv/xC8+aCjNv3p/eQW43g+WgP5kVpYGIgxS SKRQ== X-Forwarded-Encrypted: i=1; AHgh+RqdHjWTwKmHrkXkT+JOpCNvzQ4QITtoPj9PbftfPnDUwhe0+jSHtM3RY8mr12YWLk/Q8znDdzIapeMkE10=@vger.kernel.org X-Gm-Message-State: AOJu0YzPa2qskMxZyAjija7+ulcd13r1U/kCaCBkN3I16i8KUOCXOy+6 GKc5oN5q20GV6j71zri6xnvEQP61MZJbd+gTaRngWG7B+98U00zvSDb/ X-Gm-Gg: AR+sD12oublojXnQ7m1QZBb+w3BpCdW6H0zkfHLo+upBfphjPmTnHW2eFb6/75VWNbe playq+utJRIEvDq4wc4IP+zeuKnhtVhnZ/mBbUdKJqM1abwQPOfkcheCMRKVZWKK58qvPrnrq0/ O1wAb54eKTeh4FSFh2ShcAdoLN/MB3IDBXWZ+JcX7cKfNzli5tyUrFiwnfoBCbaxzPAZwl7i8Hd t9ZI11Bk7Mihwk69IDoTVgm692x33Q1A2n8jK6buNfr9n8mt1FZA+ubX1fU2ctnbjE0DLrE0rOw urjFzIF1VwGSAr25UvJMWmlNz3N/NfRIvmm9heWy2+VmQ1758frfbkonvebrfjQBtDng/UP58uj E0V3a3p3JixQrQGLFAsL63lE7IwdVnnfy0Movn6UzisWx+yvWyQWaFVU8Sp7AeHi5gqaf8pVNPn 5DoORJ5okSjcLHVCNipXLKln2PLyvakiZpYDR3JblYMZM= X-Received: by 2002:a17:90b:560b:b0:37d:f983:7b5 with SMTP id 98e67ed59e1d1-38f2939ab77mr482411a91.9.1784937582740; Fri, 24 Jul 2026 16:59:42 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:40e1:40e4:dabe:543e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d130f55c6sm47799605c88.15.2026.07.24.16.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 16:59:41 -0700 (PDT) Date: Fri, 24 Jul 2026 16:59:39 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff LaBundy Subject: Re: [PATCH] Input: iqs5xx: validate firmware record destination span Message-ID: References: <20260715083850.32155-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715083850.32155-1-pengpeng@iscas.ac.cn> On Wed, Jul 15, 2026 at 04:38:50PM +0800, Pengpeng Hou wrote: > The firmware record parser checks that the record address starts within > the programmable map, but does not check that the complete record data > fits in that map. A record near the end of the map can therefore make > the copy to pmap exceed its destination span. > > Check the record length against the remaining programmable map range > before copying the record data. > > Fixes: 7b5bb55d0dad ("Input: add support for Azoteq IQS550/572/525") > Signed-off-by: Pengpeng Hou Applied, thank you. -- Dmitry