From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: pbonzini@redhat.com, chao.gao@intel.com, kvm@vger.kernel.org
Subject: Re: [PATCH v4] KVM: VMX: Cap VMX preemption timer to work around Intel erratum
Date: Fri, 24 Jul 2026 13:56:51 -0700 [thread overview]
Message-ID: <amPRk0SfBJLQpt9X@google.com> (raw)
In-Reply-To: <20260722143024.3938899-1-jmattson@google.com>
On Wed, Jul 22, 2026, Jim Mattson wrote:
> @@ -8735,7 +8758,8 @@ __init int vmx_hardware_setup(void)
> * value. Don't use the timer if it might cause spurious exits
> * at a rate faster than 0.1 Hz (of uninterrupted guest time).
> */
> - if (use_timer_freq > 0xffffffffu / 10)
> + if (!preemption_timer_limit ||
> + use_timer_freq > (preemption_timer_limit - 1) / 10)
There's still a 64-bit DIV in here, I'm guessing it's this one.
ERROR: modpost: "__udivdi3" [arch/x86/kvm/kvm-intel.ko] undefined!
I'm not interested in playing whack-a-mole, please base v5 on my patch to make
this code 64-bit-only. It's small enough that I'm comfortable sending it to LTS
kernels if we want to tag this for stable@.
> enable_preemption_timer = false;
> }
>
> --
> 2.55.0.229.g6434b31f56-goog
>
prev parent reply other threads:[~2026-07-24 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 14:30 [PATCH v4] KVM: VMX: Cap VMX preemption timer to work around Intel erratum Jim Mattson
2026-07-24 20:56 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amPRk0SfBJLQpt9X@google.com \
--to=seanjc@google.com \
--cc=chao.gao@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.