From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBBA277035 for ; Sat, 25 Jul 2026 01:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784944001; cv=none; b=He1Cuvq2K+ygn5HFY+xBZyEH+ecbYiKFwMWYMVfsoN+fHJfzPykiXJmdqw+nodyzghb7ljEzw12yKwdlUHBCtnURg4CzP/tsvyW1SM5yxq7s5EWGdt3ajWr6+luP/E9Mxf7c1XFzvQxbfdIjfmDuV2OELkSJEiB8P7tSDQrLi+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784944001; c=relaxed/simple; bh=ToVhc3AhBahetbU3qnqMMwbQ2+rzSYcR6RO/UlkrYnM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kFMXVOPpDQrRQCZLQGErGoY6Q2JFGKCLrqNeowbM4FocW+iCS/f+prEelVkREua4CJBQdkGEXLz4BPTBSXN8J07doieRI0xZgul9lo8LBhDJch6O5Xz2oiFqtH4iXQD+jGGVhFGs0J6QbCmuaii5r/RgYHJOVHVLNOZENMiqpcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=evetzjdL; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evetzjdL" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso807748a91.1 for ; Fri, 24 Jul 2026 18:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784943999; x=1785548799; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eV48ZQHtSwmQ+39i7v6iCNrnUnn9zhxOQgslZYAxE2c=; b=evetzjdLLFT6PmhCTwkph0bX/kgsxSIURBk6XIh3EKuv8dtCAybtdGxmaYWz3Cv7UO fi/49nLPWPM0peEyKHtTeJncwc28GjMapzgXAO3Ira9yFxPiwXxt303xXC+9p+GFQX/c JTUog4ZavQaY1NCHpmIrjYQURXjCxCMniFDYbY+6R4pl5w7A65q3gZzTG+lLVehTrmEx G/65opCJ5qCWP7g0HXhhWfswkHbz61N2bzYWh/Lod02yaq6JKt8VjttLuiPzbaNNGzLF IWFtw1NDqKVc4gV5P3WSK/QBcFnzsNxtDwtDeoZs/CIIKz3ni2UQ+0LleFFfB7ZJq/Ew zOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784943999; x=1785548799; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eV48ZQHtSwmQ+39i7v6iCNrnUnn9zhxOQgslZYAxE2c=; b=Y7DDANzfPwH1Z8qqE+oE0eCP7yvjwUrDNfcsIc0aqt6DEqcvg53/Je+ZjzNZQMZ3MJ SC86cBhng4p5XBCSUcJ+owM1KhWPb2u6JVt1kr5PalRyq+M978ZQRLhwJ+VVBq2pdgNu JgRnqIW0UU9O4U2zNi4geQWpDj6zzj2y3uexEkV6RLtjgafiZXuLRy5xzKGKuZtx6ZIH ccpHjOGkCnneTOADKD8PryZQZp+kNxOEttH5RItcZZhpyQE+OMeRnp4Bcda9BzPeZ1zV 3FOzedP03DstYEUTOC5JCXKdmXCM6fKGD6t5q5izXx0eD2a5UPNxgF/q66rntXmV8k3m JbRQ== X-Forwarded-Encrypted: i=1; AHgh+RpnmAHlwjmW0zrd4BAD5QrxmSMyV5rBliuKHuKB2ejUM/RjW0dS3mN9L4LEb9lC5ryBHRfs9JUsttp622g=@vger.kernel.org X-Gm-Message-State: AOJu0YyC31zEaDHuzkta2BdPVB4j6qhANWQOwUAxTgWVkpmVTonhissS 76cIV3Ry3eMV5/yFNqlStryOpJlHry+n/w+GD6Ogf41D7NA7wjc/C6A+ X-Gm-Gg: AR+sD11FQMlDHNpHgaHRPrduj0KRYyiThqK6nRiEKY1tJlRMfHoGIMtkh5d+7N8S6Dl ECRuwe7BTHYLaDFatsSMYzfZdZ7mmZKELMTFFyyyjLa9zEhuGbDSyeXCoIbtEtaMu1CAdj8V60V qsf/ssuKpT0bonOXWEx3PPDZ1SbMJvTE6aCKfo6OCp2Bk1ZqWv1yP5nX+O7RQBxdEnXplCfU55w vcgQy/Jd3IOCF7m0cvhFHymUDUkDzEOGm3can9AUwSJT3J03xDii4qWSQ5RHIp2gzDtoh2jC7XD Y0z1Ji1bFeyVtaGoptrLqfgX+/P7G2B2WXEW40gdvZ1VGbxbMyupO0/K2Gsmh2VYWf5iPekH0rG g71sGANQcybAdeCybRSmGwhcxxCwA5embjCx2Zs290AuGiBezdyfgxa3IkwuNBo67BJ2eKBrspd gX24ToTsHM3FBwrS0iMC57avdgqkG5sLBFG/Lc8bb1ZErh6yU5Ob6YHA== X-Received: by 2002:a17:90b:5443:b0:37f:9ce1:7364 with SMTP id 98e67ed59e1d1-38f2961e0e6mr756142a91.26.1784943999088; Fri, 24 Jul 2026 18:46:39 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:40e1:40e4:dabe:543e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc548f5dsm4637809eec.17.2026.07.24.18.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 18:46:38 -0700 (PDT) Date: Fri, 24 Jul 2026 18:46:35 -0700 From: Dmitry Torokhov To: Linmao Li Cc: Haotian Zhang , Tomohiro Yoshidomi , David Rheinsberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Input: psxpad-spi - set driver data before use Message-ID: References: <20260721055551.1714965-1-lilinmao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721055551.1714965-1-lilinmao@kylinos.cn> Hi Linmao, On Tue, Jul 21, 2026 at 01:55:51PM +0800, Linmao Li wrote: > psxpad_spi_suspend() retrieves the controller state with > spi_get_drvdata(), but probe never stores it, so suspend dereferences a > NULL pointer. Store it during probe. > > Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI") > Cc: stable@vger.kernel.org > Signed-off-by: Linmao Li > --- > drivers/input/joystick/psxpad-spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/joystick/psxpad-spi.c b/drivers/input/joystick/psxpad-spi.c > index f902a56d011f..b1ab2486bb0d 100644 > --- a/drivers/input/joystick/psxpad-spi.c > +++ b/drivers/input/joystick/psxpad-spi.c > @@ -301,6 +301,7 @@ static int psxpad_spi_probe(struct spi_device *spi) > /* input poll device settings */ > pad->idev = idev; > pad->spi = spi; > + spi_set_drvdata(spi, pad); I moved the assignment to the end of probe and applied, thank you. -- Dmitry