All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Mohit Mishra <mishraloopmohit@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750fb: Remove unused function sm750_enable_dma
Date: Sat, 25 Jul 2026 11:59:45 +0300	[thread overview]
Message-ID: <amR7Afw8WeJcQBY1@stanley.mountain> (raw)
In-Reply-To: <20260725084649.106589-2-mishraloopmohit@gmail.com>

On Sat, Jul 25, 2026 at 02:16:49PM +0530, Mohit Mishra wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c
> index d617f554f58d..e4bea8da1827 100644
> --- a/drivers/staging/sm750fb/ddk750_power.c
> +++ b/drivers/staging/sm750fb/ddk750_power.c
> @@ -90,19 +90,6 @@ void sm750_enable_2d_engine(unsigned int enable)
>  	sm750_set_current_gate(gate);
>  }
>  
> -void sm750_enable_dma(unsigned int enable)
> -{
> -	u32 gate;
> -
> -	/* Enable DMA Gate */
> -	gate = peek32(CURRENT_GATE);
> -	if (enable)
> -		gate |= CURRENT_GATE_DMA;
> -	else
> -		gate &= ~CURRENT_GATE_DMA;
> -
> -	sm750_set_current_gate(gate);
> -}
>  

You need to delete the blank line afterwards as well otherwise there
are two blank lines in a row and checkpatch.pl -f will complain:

CHECK: Please don't use multiple blank lines
#93: FILE: drivers/staging/sm750fb/ddk750_power.c:93:
+
+

regards,
dan carpenter


      reply	other threads:[~2026-07-25  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25  8:46 [PATCH 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks Mohit Mishra
2026-07-25  8:46 ` [PATCH 2/2] staging: sm750fb: Remove unused function sm750_enable_dma Mohit Mishra
2026-07-25  8:59   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amR7Afw8WeJcQBY1@stanley.mountain \
    --to=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mishraloopmohit@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.