From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD632FE060 for ; Sun, 26 Jul 2026 02:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785033470; cv=none; b=V3qvp6xqY1d7DFwEcX7VPypwtBK/zLXVYY1/q+tNMZ6DRIMZ/IU0RPR2D0UqVMQG0l/QnXmmjjf5Kxbl4V3SN9BQM0Hkm0IKEU395Vbf72mxitccd4e4WiTss8TLA5Is6lq/PrNPAK9kXCBQ7T3m3L/7X5aMZGwdN9qzouC7mWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785033470; c=relaxed/simple; bh=DnZhAOmClUsjgPyiRYQ5v2c///L06Eh98JzPH/zNmEk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Py8z5jiGYjJV/4JUPB9ALXtWeBgEKqRMFNhmMYZ9bQy0IhujrhLmNbPmIiz39PVIoOmEpMl5fw4xIf62KrU8w4zcuZ04axoZtuh+UDj0osyu68y03dp0LkiHxglH71042XlariwKaGOsq1tamYrG7hzLE9+WJfSxDi99qvUB5MY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QNMc5QcE; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QNMc5QcE" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-43cce34c881so1149724fac.2 for ; Sat, 25 Jul 2026 19:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785033468; x=1785638268; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fiy5MIwEYC79lCUdHmcSHn5jPUbbQsIQK1Ub38H4x78=; b=QNMc5QcE2Rhhrzz8gt5IT0tto5FAIUxgHkiOek2sgcqdgoM/VsLgVNDTEqKFHCQQUT 4tQO6YRlhH4+UhDqOL35hkboud+sWVf2ylNzdzLgSPVSjXwez8UJWjz/g4Tz+szU9DQ1 yJoeXL6IU6IWodG+bnTyIEB+bfHjsnJYb5TzecOohioSGmkSJjY1OcisRMypf4DMA5OY hOcwysISqm/NIQWshWMI0+++HABTdSDa8aP+NPsObF2l7yvGnX03HLDv7PEj5J2Amlna N9NvBZR0EIVtLRHZw+ev7k1qz1sbSo+ZJikOAYc2OXwbCUxC9ANKOwSkrmVnkNEsAMQr uUcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785033468; x=1785638268; h=in-reply-to:content-disposition:content-type:mime-version :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fiy5MIwEYC79lCUdHmcSHn5jPUbbQsIQK1Ub38H4x78=; b=apk3gXY1EHt1jz0v1ky1isPMeXfcSv4WWwOu420AUWGKA77jKSfGPuwwC8Pujn8t8h vkcYU+5ezDy5bJv/ipTyxfnl/Mlksgqsd5Jn/XycCJWojgQUwexvCYANkBEapdcx6qiW sg9xVveMvwclFZV4bg8golCavfeoJu6CGxhYJv56NVi21EjtE/C6GKH2pSUsiehFrXyo KfuKr8hSHRXJy5Zj4x80oxogdikpV+KdPjrGPgqNy4mcY2MxL55PcBPh60WAI9TiwTX7 QynhzMv2z/oi9jwUxylZbxPyaR5imNdB3tSdtV+aJq4cTU0IGh4P19VxoQ/GanMk6I7n WOfQ== X-Forwarded-Encrypted: i=1; AHgh+Rpp/2esafuRkl67+mWoWNLhi2LxqV1G5xUhtPeJlgQfKqJIrhDq+f/k/YlXUXQ406o+dgVvTXeQI24my8k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo89si0bnjR5NmqTk/WOCzTId312XtvVqoMe61G35pjv84DrGA GDvKYuKNgaljtpxWVKbqM1e21gMyz8CcampfEt2TvicQtfS4HUc2J2mX3abBaBCE X-Gm-Gg: AR+sD12pb2/yz9aoITctNZPd/CvOxOUGK7zuloIgsyj3oXquL02OzyxjGIl9pzFkiZF Ex76h8JRqF07IDIA2x403DUACabPTndFRIeM1gelCUtx23iv00Y9SXtahe2/l7CKj7R+RKJgDs0 gzWhjIr0auVXd9FTJIfwJx94mt5NK6NiatiAAtV3ekNIKkJVkoNwCQejbo+6G/9r+Tn/vGEiJWE MNr7MM46p8uNS3rHmf5K8kv3PY6y69iAvePl4672pZPyIlo8qeeOlVSzWvWiL3Z3zBAnIYcszWT 969IAIDnPT63XVCRuzI2zBN1xf7lGHl/7Eu0prGi8p/B8wo/JFNGF01lxqDWm+/jincZE6z8Qed ZHSLCAuZKNRMNsIibsbtUNwSZ5uAh/PCKWgQihD5w6/aZE04YKwqfdzpQFJLi1aODcIhxDZDJjs GFsJiHFq0= X-Received: by 2002:a05:6808:d4b:b0:495:9870:2b25 with SMTP id 5614622812f47-4ab6a1fe862mr3734325b6e.34.1785033468220; Sat, 25 Jul 2026 19:37:48 -0700 (PDT) Received: from gmail.com ([108.243.219.47]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4ab0c7a1912sm8353622b6e.2.2026.07.25.19.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 19:37:47 -0700 (PDT) Date: Sat, 25 Jul 2026 21:37:44 -0500 From: Akash Sukhavasi To: Doug Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sashiko-reviews@lists.linux.dev Subject: Re: [PATCH] drm/panel: tdo-tl070wsh30: Use mipi_dsi_*_multi() functions Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260725170134.035EB1F000E9@smtp.kernel.org> On Sat, Jul 25, 2026 at 05:01:33PM +0000, sashiko-bot@kernel.org wrote: > [Severity: High] > Does returning early here on a DSI transmission error leave the panel in an > unrecoverable state? > > Because panel->prepared is never set to false on error, a subsequent call > to drm_panel_prepare() will immediately return 0 without re-running the > hardware initialization sequence, leaving the display permanently blank > until a system reboot. > > Could we unconditionally disable the regulator and return 0 here to ensure > the state machine remains synchronized, even if there are DSI errors? Agreed, and this is the alternative I raised below the cut in this patch. Unless anyone objects, I will send a v2 that disables the regulator unconditionally and returns 0. Sashiko AI review: https://sashiko.dev/#/patchset/20260725-mipi-dsi-tl070wsh30-multi-v1-1-69160b83982e@gmail.com?part=1 -- Thanks, Akash