All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org, maddy@linux.ibm.com,
	mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
	akpm@linux-foundation.org, baoquan.he@linux.dev,
	pasha.tatashin@soleen.com, pratyush@kernel.org, thuth@redhat.com,
	vladimir.murzin@arm.com, mark.rutland@arm.com, ardb@kernel.org,
	james.morse@arm.com, leitao@debian.org, yeoreum.yun@arm.com,
	robh@kernel.org, kees@kernel.org, coxu@redhat.com,
	sourabhjain@linux.ibm.com, ritesh.list@gmail.com,
	adityag@linux.ibm.com, hbathini@linux.ibm.com, makb@juniper.net,
	piliu@redhat.com, graf@amazon.com, liaoyuanhong@vivo.com,
	jbouron@amazon.com, bauerman@linux.ibm.com, bgwin@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	kexec@lists.infradead.org
Subject: Re: [PATCH 0/8] arm64: crash: Add crash hotplug support
Date: Sun, 26 Jul 2026 10:10:26 +0300	[thread overview]
Message-ID: <amWy4u9tXoWX6Wtp@kernel.org> (raw)
In-Reply-To: <20260723131242.1537633-1-ruanjinjie@huawei.com>

Hi Jinjie,

On Thu, Jul 23, 2026 at 09:12:34PM +0800, Jinjie Ruan wrote:
> When CPU or memory hotplug events occur, the elfcorehdr in the kdump image
> becomes stale, potentially leading to incomplete crash dumps.
> 
> Currently, userspace udev rules reload the entire kdump image upon such
> events, which is inefficient and leaves kdump inactive for a long time.
> 
> Commit 247262756121 ("crash: add generic infrastructure for crash hotplug
> support") introduced a kernel mechanism to update only the elfcorehdr.
> This patch set implements crash hotplug support for arm64.
> 
> It also addresses and fixes several critical pre-existing code issues
> and Sashiko AI review findings extracted from the previous patch set,
> following Baoquan's suggestions.
> 
> The major improvements and fixes included in this series are:
> 
> - Fix powerpc memory leak, null-ptr-def and overlapping memory
>   range truncation bug.
> 
> - Fix several memory leaks for arm64.
> 
> - Simplify arm64 load_other_segments().
> 
> - Implement infrastructure for arm64 crash memory hotplug support.
> 
> This patch set is rebased on liveupdate/crashkernel-cma.
> 
> Link: https://lore.kernel.org/all/20260601094805.2928614-1-ruanjinjie@huawei.com/
> 
> Jinjie Ruan (8):
>   powerpc/crash: Fix possible memory leak in update_crash_elfcorehdr()
>   powerpc/kexec_file: Fix null-ptr-def in extra size calculation
>   powerpc/kexec_file: Prevent kexec range truncation

It's weird to see powerpc fixes in a series that adds a feature for arm64.
Judging by the subjects, they are completely unrelated to to crash support
for hotplug and should be sent as a separate set.

>   kexec: Extract kexec_free_segment_cma() from kimage_free_cma()
>   arm64: kexec_file: Fix CMA page leaks in segment placement retry loops
>   arm64: kexec_file: Fix image->elf_headers memory leak during retry
>     loop
>   arm64: kexec_file: Simplify load_other_segments()
>   arm64: crash: Add crash hotplug support
> 
>  arch/arm64/Kconfig                     |   3 +
>  arch/arm64/include/asm/kexec.h         |  13 +++
>  arch/arm64/kernel/Makefile             |   2 +-
>  arch/arm64/kernel/crash.c              | 148 +++++++++++++++++++++++++
>  arch/arm64/kernel/kexec_image.c        |   1 +
>  arch/arm64/kernel/machine_kexec_file.c |  76 ++++++-------
>  arch/powerpc/kexec/crash.c             |   2 +-
>  arch/powerpc/kexec/file_load_64.c      |   2 +-
>  arch/powerpc/kexec/ranges.c            |  12 +-
>  include/linux/kexec.h                  |   2 +
>  kernel/kexec_core.c                    |  25 +++--
>  11 files changed, 223 insertions(+), 63 deletions(-)
>  create mode 100644 arch/arm64/kernel/crash.c
> 
> -- 
> 2.34.1
> 

-- 
Sincerely yours,
Mike.


      parent reply	other threads:[~2026-07-26  7:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 13:12 [PATCH 0/8] arm64: crash: Add crash hotplug support Jinjie Ruan
2026-07-23 13:12 ` [PATCH 1/8] powerpc/crash: Fix possible memory leak in update_crash_elfcorehdr() Jinjie Ruan
2026-07-23 13:12 ` [PATCH 2/8] powerpc/kexec_file: Fix null-ptr-def in extra size calculation Jinjie Ruan
2026-07-23 13:12 ` [PATCH 3/8] powerpc/kexec_file: Prevent kexec range truncation Jinjie Ruan
2026-07-23 13:12 ` [PATCH 4/8] kexec: Extract kexec_free_segment_cma() from kimage_free_cma() Jinjie Ruan
2026-07-23 13:12 ` [PATCH 5/8] arm64: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-07-23 13:12 ` [PATCH 6/8] arm64: kexec_file: Fix image->elf_headers memory leak during retry loop Jinjie Ruan
2026-07-23 13:12 ` [PATCH 7/8] arm64: kexec_file: Simplify load_other_segments() Jinjie Ruan
2026-07-23 13:12 ` [PATCH 8/8] arm64: crash: Add crash hotplug support Jinjie Ruan
2026-07-26  7:10 ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amWy4u9tXoWX6Wtp@kernel.org \
    --to=rppt@kernel.org \
    --cc=adityag@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=bauerman@linux.ibm.com \
    --cc=bgwin@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=chleroy@kernel.org \
    --cc=coxu@redhat.com \
    --cc=graf@amazon.com \
    --cc=hbathini@linux.ibm.com \
    --cc=james.morse@arm.com \
    --cc=jbouron@amazon.com \
    --cc=kees@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=leitao@debian.org \
    --cc=liaoyuanhong@vivo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=makb@juniper.net \
    --cc=mark.rutland@arm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=piliu@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=ritesh.list@gmail.com \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=thuth@redhat.com \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.