From: Michael Zavertkin <misha.zavertkin@mail.ru>
To: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: realtek-otto: add pinctrl support
Date: Sun, 26 Jul 2026 22:21:27 +0700 [thread overview]
Message-ID: <amYl90gvP3QSuTcP@gamepc> (raw)
In-Reply-To: <CAD++jLmXdmgWPenz=2VspSZHa4e7bWYJLyDrWDMjaEXHHKBy7Q@mail.gmail.com>
On Sat, Jul 25, 2026 at 04:10:54PM +0200, Linus Walleij wrote:
> On Sat, Jul 25, 2026 at 9:46 AM Michael Zavertkin
> <misha.zavertkin@mail.ru> wrote:
> > + if (dev_flags & GPIO_PINCTRL) {
> > + gen_gc_flags |= GPIO_GENERIC_PINCTRL_BACKEND;
> > + }
>
> Drop the ellipsis {}.
>
> With that fix:
> Reviewed-by: Linus Walleij <linusw@kernel.org>
>
> Yours,
> Linus Walleij
No problem
Should I also add pinctrl property to required in realtek,otto-gpio.yaml
for realtek,rtl9607-gpio?
next prev parent reply other threads:[~2026-07-26 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 7:46 [PATCH] gpio: realtek-otto: add pinctrl support Michael Zavertkin
2026-07-25 14:10 ` Linus Walleij
2026-07-26 15:21 ` Michael Zavertkin [this message]
2026-07-26 16:38 ` Linus Walleij
2026-07-26 17:03 ` Michael Zavertkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amYl90gvP3QSuTcP@gamepc \
--to=misha.zavertkin@mail.ru \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.