From: Willy Tarreau <w@1wt.eu>
To: Ammar Faizi <ammarfaizi2@openresty.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Kselftest Mailing List" <linux-kselftest@vger.kernel.org>,
"LLVM Mailing List" <llvm@lists.linux.dev>,
"Yichun Zhang" <yichun@openresty.com>,
"Alviro Iskandar Setiawan" <alviro.iskandar@gnuweeb.org>,
"Shuah Khan" <shuah@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
gwml@gnuweeb.org
Subject: Re: [PATCH 1/4] tools/nolibc: evaluate syscall() arguments before the arch macros
Date: Mon, 27 Jul 2026 05:42:54 +0200 [thread overview]
Message-ID: <ambTvkneo9sf0lij@1wt.eu> (raw)
In-Reply-To: <CA+KFgX76tbg_LTh6-PO-zrmhWtrjP4y3u47s1wximVFUQKq=uA@mail.gmail.com>
On Mon, Jul 27, 2026 at 08:21:45AM +0700, Ammar Faizi wrote:
> On Mon, Jul 27, 2026 at 3:16 AM Thomas Weißschuh wrote:
> > __auto_type is only supported from GCC 4.9. I think this is old enough,
> > but it should be mentioned at least.
> > We really should have a documented policy for that.
>
> I suggest using the Linux kernel's minimal requirements. It's GCC 8.1
> or Clang 17.0.1. Ref: https://docs.kernel.org/process/changes.html
>
> What do you think?
Since it's userland (i.e. not building with the kernel's compiler), and
often used for ease of porting boot-time tools in headless or embedded
environments, I'd really like that we keep compatibility for as long as
possible with oldest compilers that continue to work. Last time I checked,
it was still working fine with gcc-4.4. I still have my 4.7.4-based
toolchains that I regularly use for troublehooting and compatibility
checks (and faster builds), I can recheck. We should not require that to
be verified by contributors (too painful), however, noting "still known
to build fine with version X" is helpful. And the day we discover that
this promise has been broken for a year or so, we know we can safely
update it. I can recheck ASAP.
> Should this be documented in nolibc.h as a comment?
It can indeed be sufficient to add a line to the first comment block.
However I'm thinking that we would benefit from adding a larger README
in the sub-dir for contributors that explains some of the traps we often
have to mention.
thanks,
Willy
next prev parent reply other threads:[~2026-07-27 3:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 10:13 [PATCH 0/4] nolibc: syscall() and abs() fixes, plus a cleanup Ammar Faizi
2026-07-26 10:13 ` [PATCH 1/4] tools/nolibc: evaluate syscall() arguments before the arch macros Ammar Faizi
2026-07-26 20:16 ` Thomas Weißschuh
2026-07-27 1:21 ` Ammar Faizi
2026-07-27 3:42 ` Willy Tarreau [this message]
2026-07-27 3:30 ` Willy Tarreau
2026-07-27 16:18 ` Thomas Weißschuh
2026-07-26 10:13 ` [PATCH 2/4] tools/nolibc: stdlib: avoid signed overflow in abs() and friends Ammar Faizi
2026-07-26 14:13 ` David Laight
2026-07-26 16:01 ` Willy Tarreau
2026-07-27 7:32 ` David Laight
2026-07-27 16:15 ` Thomas Weißschuh
2026-07-26 10:13 ` [PATCH 3/4] selftests/nolibc: add abs() range test Ammar Faizi
2026-07-26 20:00 ` Thomas Weißschuh
2026-07-27 1:32 ` Ammar Faizi
2026-07-27 2:01 ` Ammar Faizi
2026-07-27 16:13 ` Thomas Weißschuh
2026-07-26 10:13 ` [PATCH 4/4] tools/nolibc: remove dead __ARCH_WANT_SYS_OLD_SELECT Ammar Faizi
2026-07-26 20:01 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ambTvkneo9sf0lij@1wt.eu \
--to=w@1wt.eu \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@openresty.com \
--cc=gwml@gnuweeb.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=shuah@kernel.org \
--cc=yichun@openresty.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.