From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FAF83FADFB for ; Mon, 27 Jul 2026 12:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785155031; cv=none; b=MfKjwORzKU35Wp9XmcRUC+wvntnzfrtmTpGVWYo3pfzQ3xpMV4X2Ixm3MvTwkwhPEKLArKF/xrvQibRMteqWlP+WquJbaG5IFBBybKitZXgFZ31O0f9S7H2gttgCkVSwDd9IYxdanLpwmISNgcAKgDvrvBwdiC/VH+xHq+eECEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785155031; c=relaxed/simple; bh=DUUtSrPmvnC24rpmZ/lujXJpOLjCH18gyESzMsgcE7c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MrxYco8hltKS99MP8956RbclS0QZUmjO/+T6RuYd6BgPes3g3Fzn/Gcs0rqG04Hnx1lzx+PvhnGCNFXWqiCgDx2AfxXfHSVmhNeUSA+9y36bC0mo7SbWx5sxWNxTGsnGc71P/aqKDoYrsJ6YOkFLAI73yTq9SQciMokD2SsTE/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YlDPWUMm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YlDPWUMm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785155029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=DUUtSrPmvnC24rpmZ/lujXJpOLjCH18gyESzMsgcE7c=; b=YlDPWUMmd7bSXQNBOJuje5pAv63QRYGt7H3SrPT8IWpiS3Az4TL888jvvSf5RAeHHCFFLl YkxXoV8lz0kLnZj3dF3fr8hKIeNFGV1GZOMnLiv69BJ3SRekgPZNIqZg5Z9l3w+ssPLpdu kkByPlSzW/7rcIl716Fq/ZbQrGJzqw8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-wFWNlJrFM7iDU5p8JYgBCQ-1; Mon, 27 Jul 2026 08:23:44 -0400 X-MC-Unique: wFWNlJrFM7iDU5p8JYgBCQ-1 X-Mimecast-MFC-AGG-ID: wFWNlJrFM7iDU5p8JYgBCQ_1785155023 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C413E180ABF5; Mon, 27 Jul 2026 12:23:40 +0000 (UTC) Received: from fedora (unknown [10.44.33.21]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 65E1B1800480; Mon, 27 Jul 2026 12:23:36 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 27 Jul 2026 14:23:40 +0200 (CEST) Date: Mon, 27 Jul 2026 14:23:34 +0200 From: Oleg Nesterov To: Breno Leitao , Christian Brauner , Mateusz Guzik , Jens Axboe Cc: Alexander Viro , Jan Kara , Alexey Gladkov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org Subject: [RFC PATCH v 0/1] pipe: only enable the extra wake_up(rd_wait) for edge-triggered consumers Message-ID: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Again, I am not sure this makes a lot of sense. But I'd like to know your opinion. Plus I'd like to have the review from sashiko ;) With or without this patch we need to update the comments to document that io_uring depends on ->pipe_usage too. And probably rename it to (say) ->et_poll. tools/testing/selftests/filesystems/epoll/epoll_wakeup_test.c passes. See also the test-cases in 1/1, they pass with this patch. And fail if I remove WRITE_ONCE(pipe->poll_usage, true) in pipe_poll(). Oleg. --- fs/pipe.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)