All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <me@ziyao.cc>
To: Eric Chung <eric.chung@riscstar.com>, Yao Zi <me@ziyao.cc>
Cc: u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org,
	Tom Rini <trini@konsulko.com>, Tim Ouyang <tim609@andestech.com>,
	Leo Liang <leo.liang@sifive.com>, Peng Fan <peng.fan@nxp.com>,
	Huan Zhou <pericycle.cc@gmail.com>,
	Raymond Mao <raymond.mao@riscstar.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
	Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
	Kaustabh Chakraborty <kauschluss@disroot.org>,
	Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
	Christoph Stoidner <c.stoidner@phytec.de>,
	Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
	Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
	Bastien Curutchet <bastien.curutchet@bootlin.com>,
	Angelo Dureghello <angelo@kernel-space.org>,
	Johan Jonker <jbx6244@gmail.com>,
	Sam Protsenko <semen.protsenko@linaro.org>,
	Guodong Xu <guodong@riscstar.com>, Rick Chen <rick@andestech.com>,
	Leo <ycliang@andestech.com>
Subject: Re: [PATCH v6 09/11] doc: spacemit: flash on K1 SoC based boards
Date: Tue, 28 Jul 2026 09:45:10 +0000	[thread overview]
Message-ID: <amh6JjTtUhi57H-b@pie> (raw)
In-Reply-To: <CAH22mJy8_gd2V_DFUT0DQYiBSO6B3u5aX-V=uD20v0G+m1cArw@mail.gmail.com>

On Tue, Jul 28, 2026 at 08:53:02AM +0800, Eric Chung wrote:
> On Tue, Jul 28, 2026 at 1:26 AM Yao Zi <me@ziyao.cc> wrote:
> >
> > On Mon, Jul 27, 2026 at 02:59:11PM +0800, Eric Chung wrote:
> > > Add document on how to flash images into eMMC of K1 SoC based boards.
> > >
> > > Signed-off-by: Eric Chung <eric.chung@riscstar.com>
> > >
> > > ---
> > > v3:
> > > - Add document on how to flash images into SD card.
> > > ---
> > >  board/spacemit/k1/MAINTAINERS |   2 +-
> > >  doc/board/spacemit/index.rst  |   1 +
> > >  doc/board/spacemit/k1-mmc.rst | 320 ++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 322 insertions(+), 1 deletion(-)
> >
> > ...
> >
> > > diff --git a/doc/board/spacemit/k1-mmc.rst b/doc/board/spacemit/k1-mmc.rst
> > > new file mode 100644
> > > index 00000000000..b0fe78c75ce
> > > --- /dev/null
> > > +++ b/doc/board/spacemit/k1-mmc.rst
> > > @@ -0,0 +1,320 @@
> >
> > ...
> >
> > > +Chapter 2: SD Card Boot
> > > +=======================
> > > +
> > > +
> > > +SpacemiT K1 Bianbu SD Card Image Flashing and U-Boot Update Guide
> > > +==================================================================
> > > +
> > > +This guide explains how to prepare a bootable SD card with Bianbu OS for
> > > +SpacemiT K1 based boards and how to replace the U-Boot binary on the SD
> > > +card with a custom build.
> > > +
> > > +Prerequisites
> > > +~~~~~~~~~~~~~
> > > +
> > > +- A SpacemiT K1 based development board
> > > +- A microSD card (at least 8 GB capacity recommended)
> > > +- A card reader for your host computer
> > > +- A Linux host system (for ``dd``, ``fdisk``, ``lsblk`` commands)
> > > +- The Bianbu SD card image from
> > > +   <https://spacemit.com/community/resources-download/Images%20Collects/K1/Bianbu>
> > > +- A custom ``u-boot.itb`` file (device tree blob or U-Boot FIT image) to be
> > > +  written to the U-Boot partition
> > > +
> > > +Prepare the SD Card & the image
> > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > +
> > > +**1. Download the image**
> > > +
> > > +Download the released package from the official SpacemiT website:
> > > +
> > > +<https://archive.spacemit.com/image/k1/version/bianbu/v2.3.5/Bianbu-Minimal-K1-sdcard-V2.3.5-20260601180942.img.zip>
> > > +
> > > +**2. Extract the image**
> > > +
> > > +.. code-block:: console
> > > +
> > > +   $ unzip Bianbu-Minimal-K1-sdcard-V2.3.5-20260601180942.img.zip
> > > +
> > > +**3. Identify the SD card device**
> > > +
> > > +Insert the microSD card into your card reader, then run:
> > > +
> > > +.. code-block:: console
> > > +
> > > +   $ lsblk
> > > +
> > > +Compare the output before and after inserting the card to identify
> > > +the new device. It will typically appear as ``/dev/sdb``, ``/dev/sdc``,
> > > +or ``/dev/mmcblk0``.
> > > +
> > > +**4. Write the image to the SD card**
> > > +
> > > +.. code-block:: console
> > > +
> > > +   $ sudo dd if=./Bianbu-Minimal-K1-sdcard-V2.3.5-20260601180942.img of=/dev/sdb bs=1M status=progress
> > > +
> > > +The SD card is now ready as a bootable Bianbu system disk.
> >
> > This looks out of scope of describing how to create a bootable SD card
> > with U-Boot. In my opinion, you'd better describe the requirements of
> > parition layout and image position for SD-card booting, to allow readers
> > to create their own images/bootable medium from scratch more easily,
> > instead of sticking to the vendored image.
> >
> 
> Creating a bootable SD card from scratch would be valuable, but I'll address
> it later due to time constraints.

In case I didn't make myself clear enough, the documentation *SHOULD*
describe how to create bootable devices from scratch, instead of
alternating an existing OS image to use mainline U-Boot. I don't think
the current documentation helps much for downstream users/distributions
to adapt U-Boot for their own use cases, or at least it could be written
in a much more clear, vendor-neutral way.

So here's my NAK for this patch. I'm not sure what you mean by "time
constraints", but please keep submitted patches in a good shape.

Thanks,
Yao Zi

  reply	other threads:[~2026-07-28  9:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  6:59 [PATCH v6 00/11] spacemit mmc driver Eric Chung
2026-07-27  6:59 ` [PATCH v6 01/11] spacemit: k1: select boot device via config registers Eric Chung
2026-07-27  6:59 ` [PATCH v6 02/11] pinctrl: k1: fix drive strength configuration Eric Chung
2026-07-27  6:59 ` [PATCH v6 03/11] pinctrl: k1: fix pull-up/pull-down configuration Eric Chung
2026-07-27  8:20   ` Yao Zi
2026-07-27  8:24     ` Yao Zi
2026-07-27  6:59 ` [PATCH v6 04/11] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-07-28 17:15   ` Junhui Liu
2026-07-27  6:59 ` [PATCH v6 05/11] mmc: k1: add sdhci platform driver Eric Chung
2026-07-27  6:59 ` [PATCH v6 06/11] dts: k1: add SD card support in u-boot overlay Eric Chung
2026-07-27 11:51   ` Yao Zi
2026-07-27 13:08     ` Eric Chung
2026-07-27 17:07       ` Yao Zi
2026-07-28  1:04         ` Eric Chung
2026-07-28  9:10           ` Yao Zi
2026-07-29 14:05             ` Eric Chung
2026-07-29 15:58               ` Yao Zi
2026-07-30  5:18                 ` Eric Chung
2026-07-27  6:59 ` [PATCH v6 07/11] configs: k1: enable SD and eMMC support Eric Chung
2026-07-27 17:15   ` Yao Zi
2026-07-27  6:59 ` [PATCH v6 08/11] MAINTAINER: update Spacemit K1 entry Eric Chung
2026-07-27  6:59 ` [PATCH v6 09/11] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-07-27 17:26   ` Yao Zi
2026-07-28  0:53     ` Eric Chung
2026-07-28  9:45       ` Yao Zi [this message]
2026-07-29 13:49         ` Eric Chung
2026-07-29 15:32           ` Yao Zi
2026-07-30  6:25             ` Eric Chung
2026-07-30 15:20               ` Yao Zi
2026-07-31  0:31                 ` Eric Chung
2026-07-27  6:59 ` [PATCH v6 10/11] config: k1: enable ENV support for eMMC Eric Chung
2026-07-27  6:59 ` [PATCH v6 11/11] spacemit: k1: load product name from environment variable Eric Chung
2026-07-27 17:41   ` Yao Zi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amh6JjTtUhi57H-b@pie \
    --to=me@ziyao.cc \
    --cc=angelo@kernel-space.org \
    --cc=anshuld@ti.com \
    --cc=balsundar.ponnusamy@altera.com \
    --cc=bastien.curutchet@bootlin.com \
    --cc=bhimeswararao.matsa@gmail.com \
    --cc=c.stoidner@phytec.de \
    --cc=daniel@thingy.jp \
    --cc=eric.chung@riscstar.com \
    --cc=guodong@riscstar.com \
    --cc=han.xu@nxp.com \
    --cc=jbx6244@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=kauschluss@disroot.org \
    --cc=leo.liang@sifive.com \
    --cc=peng.fan@nxp.com \
    --cc=pericycle.cc@gmail.com \
    --cc=raymond.mao@riscstar.com \
    --cc=rick@andestech.com \
    --cc=semen.protsenko@linaro.org \
    --cc=tanmay.kathpalia@altera.com \
    --cc=tim609@andestech.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-spacemit@groups.io \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=yanir.levin@tandemg.com \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.