From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Tushar Vyavahare <tushar.vyavahare@intel.com>
Cc: <netdev@vger.kernel.org>, <magnus.karlsson@intel.com>,
<stfomichev@gmail.com>, <kernelxing@tencent.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<ast@kernel.org>, <daniel@iogearbox.net>,
<tirthendu.sarkar@intel.com>, <andrii.nakryiko@gmail.com>,
<bpf@vger.kernel.org>
Subject: Re: [PATCH net-next v2] selftests/xsk: decouple xskxceiver and xdp apps from test_progs objects
Date: Tue, 28 Jul 2026 11:59:37 +0200 [thread overview]
Message-ID: <amh9ibVsNipHg8VH@boxer> (raw)
In-Reply-To: <20260728060758.1970618-1-tushar.vyavahare@intel.com>
On Tue, Jul 28, 2026 at 06:07:58AM +0000, Tushar Vyavahare wrote:
> Build xskxceiver, xdp_hw_metadata, and xdp_features from explicit source
> lists instead of reusing helper objects produced by test_progs rules.
>
> Reusing shared objects such as network_helpers.o and xsk.o can pull in
> test_progs-only dependency chains and trigger unrelated libarena builds
> when invoking a single target.
>
> Keep these standalone binaries self-contained so each target builds only
> its own required sources and BPF skeleton dependencies.
>
> ---
> v2:
> - Inline dependency lists in tools/testing/selftests/bpf/Makefile.
> - Drop *_SRC helper variables per review feedback.
>
> Signed-off-by: Tushar Vyavahare <tushar.vyavahare@intel.com>
Your SoB should go above ---
Tested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> tools/testing/selftests/bpf/Makefile | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index b642ee489ea6..f4e78bf8ec80 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -934,17 +934,26 @@ $(OUTPUT)/test_verifier: test_verifier.c verifier/tests.h $(BPFOBJ) | $(OUTPUT)
> $(call msg,BINARY,,$@)
> $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@
>
> -# Include find_bit.c to compile xskxceiver.
> -EXTRA_SRC := $(TOOLSDIR)/lib/find_bit.c prog_tests/test_xsk.c prog_tests/test_xsk.h
> -$(OUTPUT)/xskxceiver: $(EXTRA_SRC) xskxceiver.c xskxceiver.h $(OUTPUT)/network_helpers.o $(OUTPUT)/xsk.o $(OUTPUT)/xsk_xdp_progs.skel.h $(BPFOBJ) | $(OUTPUT)
> +# Keep xskxceiver independent from test_progs object dependencies.
> +$(OUTPUT)/xskxceiver: xskxceiver.c xsk.c network_helpers.c \
> + $(TOOLSDIR)/lib/find_bit.c prog_tests/test_xsk.c \
> + xskxceiver.h xsk.h network_helpers.h \
> + prog_tests/test_xsk.h test_progs.h bpf_util.h \
> + $(OUTPUT)/xsk_xdp_progs.skel.h $(BPFOBJ) | $(OUTPUT)
> $(call msg,BINARY,,$@)
> $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@
>
> -$(OUTPUT)/xdp_hw_metadata: xdp_hw_metadata.c $(OUTPUT)/network_helpers.o $(OUTPUT)/xsk.o $(OUTPUT)/xdp_hw_metadata.skel.h | $(OUTPUT)
> +$(OUTPUT)/xdp_hw_metadata: xdp_hw_metadata.c xsk.c network_helpers.c \
> + $(TOOLSDIR)/lib/find_bit.c xdp_metadata.h \
> + xsk.h network_helpers.h test_progs.h bpf_util.h \
> + $(OUTPUT)/xdp_hw_metadata.skel.h $(BPFOBJ) | $(OUTPUT)
> $(call msg,BINARY,,$@)
> $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@
>
> -$(OUTPUT)/xdp_features: xdp_features.c $(OUTPUT)/network_helpers.o $(OUTPUT)/xdp_features.skel.h | $(OUTPUT)
> +$(OUTPUT)/xdp_features: xdp_features.c network_helpers.c xdp_features.h \
> + network_helpers.h \
> + test_progs.h bpf_util.h $(OUTPUT)/xdp_features.skel.h \
> + $(BPFOBJ) | $(OUTPUT)
> $(call msg,BINARY,,$@)
> $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@
>
> --
> 2.43.0
>
prev parent reply other threads:[~2026-07-28 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 6:07 [PATCH net-next v2] selftests/xsk: decouple xskxceiver and xdp apps from test_progs objects Tushar Vyavahare
2026-07-28 9:59 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amh9ibVsNipHg8VH@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
--cc=tirthendu.sarkar@intel.com \
--cc=tushar.vyavahare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.