Re: [PATCH v2] xfs: test xfsdump subtree restores

[Zorro Lang <zlang@kernel.org>]

On Mon, Jul 27, 2026 at 08:25:26PM -0700, Christoph Hellwig wrote:
> On Thu, Jul 23, 2026 at 04:26:17PM +1000, Donald Douwsma wrote:
> > +
> > +_do "Creating l2 dump" "$XFSDUMP_PROG -L lab_l2.0 -M test -l2 -f $tmp.dump.l2.0 $SCRATCH_MNT"
> > +
> > +dir=$(mktemp -d $SCRATCH_MNT/restore_XXX)
> > +_do "Cumulative restore l0" "$XFSRESTORE_PROG -f $tmp.dump.l0 -r $dir"
> > +_do "Cumulative restore l2" "$XFSRESTORE_PROG -f $tmp.dump.l2.0 -r $dir"
> > +
> > +dir=$(mktemp -d $SCRATCH_MNT/restore_XXX)
> > +_do "Cumulative subtree restore l0" "$XFSRESTORE_PROG -f $tmp.dump.l0 -r -s restore_me $dir"
> > +# The next command core dumps prior to xfsdump v3.3.0 when noref_elim_recurse attempts to
> > +# rename directories outside of the subtree when their parent has not been created.
> > +_do "Cumulative subtree restore l2" "$XFSRESTORE_PROG -f $tmp.dump.l2.0 -r $dir"
> 
> Maybe break these lines up with \ after the description to make
> it a bit more readable?

Sure, I'll help to do this change when I merge it. Thanks Christoph!

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
>