From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6125FC53219 for ; Tue, 28 Jul 2026 21:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2YfnO85vgmRFXPITWoFPuqv3tUfLL+rhOUAQTbi0T6w=; b=xFMdkCsCX01wRm +NJp7qOuth1zevXyiZUjwj2GFiRXCzzBc/numN/X52U6sJDq0CC/lulqmR0feCgrtiWtMO9zrttX7 g2HeOWNSGgsuomLqKbYBnxoPOFVKUGIGLJBYalRcKSb3dGZ8N+As7y6OLfI8D7jKk53cQfYuEcMxE cMqM+bPEZV93QRoSY50ru1bDaz8WqR6RLH6KcNyJYnmByLDAV49umEJS6e2y31qrXpoIpu67hAoiQ y+MO9wfwK6Ois40Chgjv2VXqQbThg45ts5hI4tw9XQfd3qtu/9rs12n28THxxSOGRbKFO3Zl8ELfm swSOe1zxITNw/XKPwoBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wopbX-00000006MML-2W7w; Tue, 28 Jul 2026 21:44:51 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wopbV-00000006MLv-2xB2 for linux-phy@lists.infradead.org; Tue, 28 Jul 2026 21:44:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id C2F4460A5E; Tue, 28 Jul 2026 21:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EE3F1F000E9; Tue, 28 Jul 2026 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785275088; bh=ydnGs5+SvUGu/cMH0rWpcTt/UFbIzII65j9MTyYxVuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LFJZswlJbEZ5vCLjwKbIc+cUiUQu4KuMDbtT9X0e0fVpXUZ2lwxtWE7LDD+adU5uB bQQwcJvtW510W7ZYm344cpnMROEbSEoG2xRWx8YIw3L52POaUSaVhOzzMRRNsPuhKd DfLsBSf5/qW0MCeToYHyYtYAvLjiM3x8vzOklguIcu0CQvwM+HblPMBGMIPEbtK61o jZLPz3sUXECucqlTgSslsLiGMF6XHYV3YnhzoJVI69xtcz7Cc0l+d+8JNhd5AoAciQ nG3UbgjpTs7/WPFiIp/cVZln5NCXKb7h0AoDwooGM7B66r6P2z//3nBgT0Q2pRWEnO xY4L9srP0vZwQ== Date: Tue, 28 Jul 2026 14:44:46 -0700 From: Drew Fustini To: Icenowy Zheng Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wei Fu , Drew Fustini , Jisheng Zhang , Philipp Zabel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Han Gao , Yao Zi , Icenowy Zheng Subject: Re: [PATCH v2 2/2] phy: add a driver for T-Head TH1520 USB PHY Message-ID: References: <20260723084316.3573714-1-zhengxingda@iscas.ac.cn> <20260723084316.3573714-3-zhengxingda@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260723084316.3573714-3-zhengxingda@iscas.ac.cn> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2026 at 04:43:16PM +0800, Icenowy Zheng wrote: > The USB PHY on T-Head TH1520 SoC is a Synopsys USB 3.0 FemtoPHY, with > some PHY parameters exported as another system controller along with it. > > As a few PHY parameters' default value isn't ready to work, add a driver > configuring them before letting the PHY run, in addition to > clock/reset/regulator management. The second paragragh might read better as: "A few PHY parameters have unusable defaults. Add a driver that programs them before releasing the PHY from reset. [..]" Thanks, Drew -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B428B3BE652; Tue, 28 Jul 2026 21:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785275089; cv=none; b=QivZTYkVgb9StXflbpTqrjL/R8T7ocIDz2S/9IPcWufsipwB5IGXc58ELWI9eBLsDIlrnA3Zcex/f5VOshT/WP9rhQf1CoODMSqbdhjqFrT43hpgePhIkaOjwwLMdX4Exrf0DMKZfObXC140x+mzKWBqGHYAhOcN9x64dWJaAig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785275089; c=relaxed/simple; bh=U7spWcY0H8vLDHg6cxrAcR0wDjCwQpic/rcHbeuIKrg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pz+pvZaaiLW1EIOjZ9AC/4lHPs+BF7kGaO/9PU+O05Uesvz1FWWWi2xUCUZ/ulGvI7Ztn9T7UPxhVcFQv9R6FK/CNq/KKYg0eeqF9kOvcohXA8Yxcw96i95CCewE0ib/4PfZZLbI+bXK8KJkIaNIEugBdDU0TfSoQyeota5yIFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LFJZswlJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LFJZswlJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EE3F1F000E9; Tue, 28 Jul 2026 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785275088; bh=ydnGs5+SvUGu/cMH0rWpcTt/UFbIzII65j9MTyYxVuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LFJZswlJbEZ5vCLjwKbIc+cUiUQu4KuMDbtT9X0e0fVpXUZ2lwxtWE7LDD+adU5uB bQQwcJvtW510W7ZYm344cpnMROEbSEoG2xRWx8YIw3L52POaUSaVhOzzMRRNsPuhKd DfLsBSf5/qW0MCeToYHyYtYAvLjiM3x8vzOklguIcu0CQvwM+HblPMBGMIPEbtK61o jZLPz3sUXECucqlTgSslsLiGMF6XHYV3YnhzoJVI69xtcz7Cc0l+d+8JNhd5AoAciQ nG3UbgjpTs7/WPFiIp/cVZln5NCXKb7h0AoDwooGM7B66r6P2z//3nBgT0Q2pRWEnO xY4L9srP0vZwQ== Date: Tue, 28 Jul 2026 14:44:46 -0700 From: Drew Fustini To: Icenowy Zheng Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wei Fu , Drew Fustini , Jisheng Zhang , Philipp Zabel , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Han Gao , Yao Zi , Icenowy Zheng Subject: Re: [PATCH v2 2/2] phy: add a driver for T-Head TH1520 USB PHY Message-ID: References: <20260723084316.3573714-1-zhengxingda@iscas.ac.cn> <20260723084316.3573714-3-zhengxingda@iscas.ac.cn> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723084316.3573714-3-zhengxingda@iscas.ac.cn> On Thu, Jul 23, 2026 at 04:43:16PM +0800, Icenowy Zheng wrote: > The USB PHY on T-Head TH1520 SoC is a Synopsys USB 3.0 FemtoPHY, with > some PHY parameters exported as another system controller along with it. > > As a few PHY parameters' default value isn't ready to work, add a driver > configuring them before letting the PHY run, in addition to > clock/reset/regulator management. The second paragragh might read better as: "A few PHY parameters have unusable defaults. Add a driver that programs them before releasing the PHY from reset. [..]" Thanks, Drew