Re: [PATCH v4 14/17] media: em28xx: Add include for struct usb_device_id

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

Hello,

On Mon, Jul 27, 2026 at 12:14:51PM +0200, Hans Verkuil wrote:
> On 30/06/2026 11:24, Uwe Kleine-König (The Capable Hub) wrote:
> > Traditionally <linux/mod_devicetable.h> was a header defining a plethora
> > of structs, among them struct usb_device_id. This was split now with the
> > objective that only the relevant bits are included.
> > 
> > Currently <linux/mod_devicetable.h> is transitively included in
> > drivers/media/usb/em28xx/em28xx.h via:
> > 
> > 	drivers/media/usb/em28xx/em28xx.h ->
> > 	<linux/i2c.h> ->
> > 	<linux/acpi.h> ->
> > 	<linux/device.h> ->
> > 	<linux/device/driver.h> ->
> > 	<linux/mod_devicetable.h
> > 
> > To keep struct usb_device_id available once <linux/device/driver.h>
> > stops including <linux/mod_devicetable.h>, include it the header
> > providing that struct explictly.
> > 
> > Acked-by: Danilo Krummrich <dakr@kernel.org>
> > Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> > Link: https://patch.msgid.link/b859817d9f6ec7450302a231e093a5ad5852cb91.1782682124.git.ukleinek@kernel.org
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> Acked-by: Hans Verkuil <hverkuil+cisco@kernel.org>

Note you're late to the party. This patch already became commit
c19f08f796cb ("media: em28xx: Add include for struct usb_device_id") and
is part of v7.2-rc2.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]