From: Raag Jadav <raag.jadav@intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Ramesh Babu B" <ramesh.babu.b@intel.com>,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org,
stable@vger.kernel.org
Subject: Re: [PATCH v6 3/3] drm/xe/i2c: Keep the i2c controller always enabled
Date: Wed, 29 Jul 2026 17:34:26 +0200 [thread overview]
Message-ID: <amodgov-jMqxPiwV@black.igk.intel.com> (raw)
In-Reply-To: <20260722133554.2079612-4-heikki.krogerus@linux.intel.com>
On Wed, Jul 22, 2026 at 03:35:54PM +0200, Heikki Krogerus wrote:
> Some platforms make an assumption that the i2c controller's
> enabled state indicates also the power state of the
> controller. This can create a problem when the controller is
> in disabled state, because the hardware may assume
> incorrectly that it is then also in low-power state.
>
> To fix this, the controller is kept enabled by taking over
> the IC_ENABLE register. The controller has to be disabled
> when the configuration is updated and when the target
> address or the slave address are assigned, so disabling it
> when IC_CON, IC_TAR or IC_SAR registers are programmed, and
> then re-enabling it again.
>
> Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
I'll rely on Andy and Mika's disposition on this one.
Raag
next prev parent reply other threads:[~2026-07-29 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 13:35 [PATCH v6 0/3] drm/xe/i2c: alerts and controller enabling modifications Heikki Krogerus
2026-07-22 13:35 ` [PATCH v6 1/3] i2c: designware: Global register definitions Heikki Krogerus
2026-07-22 13:35 ` [PATCH v6 2/3] drm/xe/i2c: Fix the interrupt handling Heikki Krogerus
2026-07-29 15:30 ` Raag Jadav
2026-07-22 13:35 ` [PATCH v6 3/3] drm/xe/i2c: Keep the i2c controller always enabled Heikki Krogerus
2026-07-29 15:34 ` Raag Jadav [this message]
2026-07-22 16:28 ` ✗ CI.checkpatch: warning for drm/xe/i2c: alerts and controller enabling modifications (rev6) Patchwork
2026-07-22 16:30 ` ✓ CI.KUnit: success " Patchwork
2026-07-22 17:50 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-23 11:17 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-28 15:50 ` [PATCH v6 0/3] drm/xe/i2c: alerts and controller enabling modifications Heikki Krogerus
2026-07-29 15:24 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amodgov-jMqxPiwV@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=ramesh.babu.b@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.