All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Paul Louvel <paul.louvel@bootlin.com>
Cc: Ignat Korchagin <ignat@linux.win>,
	Stefan Berger <stefanb@linux.ibm.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] crypto: ecc - Add NIST P224 curve parameters
Date: Wed, 29 Jul 2026 20:28:49 +0200	[thread overview]
Message-ID: <ampGYdgcMMDasJ5y@wunner.de> (raw)
In-Reply-To: <20260729-add-nist-p224-curve-v1-1-334dfbe16683@bootlin.com>

On Wed, Jul 29, 2026 at 05:51:04PM +0200, Paul Louvel wrote:
> Add the parameters for the NIST P224 curve and define a new curve ID for
> it. Make the curve available in ecc_get_curve().

Usually we'd also want test vectors in crypto/testmgr.h.

> +static struct ecc_curve nist_p224 = {
> +	.name = "nist_224",
> +	.nbits = 224,
> +	.g = {
> +		.x = nist_p224_g_x,
> +		.y = nist_p224_g_y,
> +		.ndigits = 4,

This should be 3 because DIV_ROUND_UP(224, 64) = 3.

Thanks,

Lukas

      parent reply	other threads:[~2026-07-29 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 15:51 [PATCH] crypto: ecc - Add NIST P224 curve parameters Paul Louvel
2026-07-29 16:43 ` Thomas Huth
2026-07-29 19:06   ` Paul Louvel
2026-07-29 19:37     ` Simo Sorce
2026-07-29 16:50 ` Simo Sorce
2026-07-29 18:28 ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ampGYdgcMMDasJ5y@wunner.de \
    --to=lukas@wunner.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@linux.win \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.louvel@bootlin.com \
    --cc=stefanb@linux.ibm.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.